Sodium

Sodium

35M Downloads

Breaking any blocks would cause it to render very dark until relog

CalXee opened this issue ยท 3 comments

commented

This happens in combination with PhilPro's Lighting Fixes mod.

This bug causes lighting to never update after joining a world or server. For example if it's dark at night, and you place a torch, the torch won't light up its surroundings until you relog. Similarly, after you relog, breaking the torch causes light to still be there.
Obviously, if a block is covered by other blocks, it'll be rendered very dark since no light is touching it. Normally, when you remove the block the light would update and cause the exposed block to be bright. That updating process seems to be absent with this mod.

Expected Behavior

Blocks render bright as it's exposed to skylight

Actual Behavior

Breaking a block that uncovers another block causes it to be extremely dark.

Reproduction Steps

  1. Go into any world
  2. Break a block
    Results: There is a very dark shadow

2020-09-30_14 30 42
2020-10-04_15 41 51
2020-10-04_15 41 59

commented

This has been fixed on Phosphor's end in CaffeineMC/phosphor-fabric#26. Should probably close this.

commented

If this bug report was referring to lighting-fixes as it says, it seems like this was addressed there before it was even reported here - see PhiProven/mc-fixes#1
In brief testing I can't reproduce the issue (using Sodium's next branch), so closing this now.

commented

How does it happen? I cannot reproduce it (maybe because of phosphor).