Reimplement the option to change the fog type

Question

Reimplement the option to change the fog type

cavallium opened this issue 4 years ago · 4 comments

cavallium commented 4 years ago

Is your feature request related to a problem? Please describe.
Minecraft allows you to disable fog. Sodium doesn't.

Describe the solution you'd like
ChunkFogMode.java has already the possibility to change the fog type, in getActiveMode().
Add an option to disable fog, so that if the option is true the function returns ChunkFogMode.NONE.

jellysquid3 · Answer 1 · 2020-12-22T00:06:22.000Z

What option in Minecraft allows you to disable fog?

cavallium · Answer 2 · 2020-12-22T00:08:10.000Z

Sorry probably it was in OptiFine

cavallium · Answer 3 · 2020-12-22T00:09:26.000Z

By the way, changing it to none seems to work well, so it can be implemented in Sodium.

jellysquid3 · Answer 4 · 2020-12-22T00:22:15.000Z

The point of this function is that if another mod calls glDisable(GL11.GL_FOG) (as effectively all other fog-disabling mods do) that the getActiveMode() function will see the state change and return ChunkFogMode.NONE. There is nothing for Sodium to implement here.

Share to