Sodium

Sodium

35M Downloads

Cauldron looks odd underwater

FewerFlaws opened this issue ยท 6 comments

commented

Expected Behavior

The cauldron should look the same underwater as it does above water.

Actual Behavior

The outermost layer an underwater's cauldron's skin is removed when viewed from above trhe water; likely an issue with the moving water texture.

Reproduction Steps

  1. Find a lake.
  2. Place a cauldron underwater.
  3. Observe the cauldron from air and from within the water.

Attachments

2021-01-06_15 28 28
(Sodium) Underwater cauldron viewed from air.

2021-01-06_15 28 26_2
(Sodium) Underwater cauldron viewed from underwater.

2021-01-06_15 30 25
(Vanilla) Underwater cauldron viewed from underwater.

System Information

  • Java Version: 1.8.0_271
  • CPU: Core i7-3770
  • GPU: GTX 1060

2021-01-06_15 39 38

commented

Resolved in 0.4.10, probably same issue as #394

commented

I can't reproduce this issue. For me it looks exactly as in vanilla.

Sodium:
2021-01-10_15 05 02

Vanilla:
2021-01-10_15 15 41

I guess this could be an Nvidia driver issue, since you are using an Nvidia gpu and I'm using AMD.

commented

Interesting. Upon a bit of further investigation I immediately notice that the running water texture sometimes disappears and doesn't always cause this issue. In the screenshots I originally posted you can see that the running water texture is z-fighting with the cauldron side.

One potentially relevant thing to mention is that I have "use compact vertex format" turned off. I'll do some more investigation.

Here's a couple screenshots showing the running water texture disappearing when viewed from slightly different angles:
2021-01-10_10 09 59
2021-01-10_10 09 57

commented

Oh, here we go. I duplicated the issue using viewing angles and made a video right here.

commented

Okay so I tried sodium-fabric-mc1.16.4-0.1.1-SNAPSHOT-1609237523.jar, that can be found on the #mod-testers channel on JellySquid's discord. With it there are no bugs with the flowing water texture when looking at it from below the water surface. However that version still has rendering bugs when looking at the flowing water texture from above the water surface.

commented

I wouldn't say that the cauldron's side not rendering is for sure z-fighting. I still can't reproduce the cauldron side texture not rendering even when trying weird angles. I do have the same issue with the flowing water textures not rendering from some angles though.

Here is a video of the rendering bugs (pretty bad quality because I don't usually record my screen on Linux and 1440p monitor makes it harder). I also tried with vanilla and the only difference was that the flowing water texture was always visible on all sides of the cauldron.

These are the settings I'm using
2021-01-14_13 02 45
2021-01-14_13 02 47