Blockentity with color not rendered correctly
XcusanaIi opened this issue · 11 comments
Version information
sodium-fabric-mc1.17.1-0.3.0+build.5
Expected Behavior
Actual Behavior
Reproduction Steps
1.Install Sodium and another mod that has blockentity with a block color provider
2.The blockentity is rendered in a strange way
Java version
Java 16
CPU
Intel Core i5-10400F
GPU
NVIDIA GeForce GTX 1650 SUPER
Additional information
No response
Sodium is forcefully blending every color provider incorrectly because our logic is backwards here. This needs to be fixed on our side.
Can you check if 634b11e fixes the problem?
Was wondering if there was an update for this, the behavior stills seems to happen. Biome Blending turned off fixes the issue, if that helps in any way
Can you check if 634b11e fixes the problem?
I've ported 634b11e in 1.19 and tested with my "tun" block, and can confirm it works.
This block is a block entity with an item on its inventory, then the "liquid" inside is colored with a color provider basing on the item (the content), because of that it requires the precise block position and blending its color with other ajacent blocks make no sense.
TunBlock.java#L235
Normal:
With fix:
Test for supported blocks: (E.g Grass)
The porting is here #1360 if you are interested, I've also added a way for modders to register new blocks for smooth blending (technically the opposite of #1331 by using the experimental commit), for example if they add new leaves... and added missing 1.18 and 1.19 leaves (I don't know if there are other 1.18 missing blocks... e.g moss??).
Looks like there was some work back in June that fixed the issue but got lost. I am see this issue in 1.19.2 - 4.4.0 Sodium currently with my Incense Candle block for my Bumblezone mod. Will the fix be looked into again and ported to 1.19.2 and released?
Currently, I found another modder who had the same issue and their solution was to mixin into Sodium but I rather not have to do that
While waiting for this to get officially patched, I've included the fix made in commit 634b11e, ported in #1360 from 1.17, into a mod named "Sodium Blending Registry" that includes the c:blendable tag too: https://modrinth.com/mod/sodium-blendingregistry
The patch is for the latest version of sodium.
We have a new version of the patch which fixes a lot of issues (commit 651276f). The fix will be published with Sodium 0.5, which is the upcoming release... hopefully in the next 2-3 weeks.
There was a lot of work done on the color blending stuff to fix performance/bugs, as Sodium's implementation is a little dumb (incorrectly blended all blocks, including Redstone Wire).
The issue will be closed, but kept with R-pending-release until an actual release of the mod is published with the fix.
