Issue description

Basically when I am switching between compounding, tapping, storing, or burning various metals through allomancy and feruchemy the game will crash. Allomancy seems to be the trigger factor here, as the 3 logs I can recall all mentioned an allomancy metal in the crash logs (Brass, Pewter, Zinc)

Steps to reproduce

1. Have access to all metals
2. Compound all metals (except duralumin, aluminum, cadmium, bendalloy, nicrosil, chromium, bronze)
3. Set feruchemy versions of above metals to storing as well
4. Once every metal has charges (feruchemy), switch feruchemy to tapping and allomancy to burning (All relevant feruchemy first, then sequentially begin burning all relevant allomancy)
5. At some point in switching the allomancy to burning, crash occurs (though the metal that triggers has varied for me)

Note: I updated to latest forge version and produced these exact same effects. Leaving the original version as well

Minecraft version

1.20.1 (Latest)

Modloader version

47.3.0

Cosmere version

0.7.97

Other relevant versions

Feruchemy, Allomancy, and Hemalurgy are also all up to date since the january update. Below is 1 log with the same effect prior to that update and 3 after the latest updates.

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

https://mclo.gs/IPSXB61 https://mclo.gs/r8CBbjf https://mclo.gs/stwKFrf https://mclo.gs/uKKJnfh

No clue why it's happening, but what's going on is that the server side, which exists even in singleplayer, gets a non-existent return on getting a thread for a player, of which there should only be one. My best guess is that since we assume the metal is burning if we're in applyEffectTick, we create an entry for a thread that doesn't exist, so when you switch it to burning, it tries to get said thread that doesn't exist and has a fit.

I'm just gonna add a null check. Should be fine. Note that I couldn't actually replicate the results, so there might be some kind of race condition going on.

Also, the pewter thing was an unrelated bug to do with, well, pewter. I hadn't registered the delayed pewter damage type properly in porting, and we didn't catch the mistake before releasing.

I'll close this issue in a sec, since I think what I've done fixed the issue. If this happens again once we update the mod, please do reopen it or open a new one or whatever. If you'd like to be extra sure, I could provide newer jars, as well.