Survival Inc.

Survival Inc.

13.3k Downloads

Integration with Elenai Doge 2

hasuu opened this issue ยท 16 comments

commented

Dodge wont work with Survival Inc. installed.
I already posted it on Elenai Doge Github.
Link to the mod: https://www.curseforge.com/minecraft/mc-mods/elenai-dodge-2

commented

Won't work

This one. What doesn't work? Does the game crash? Is the game buggy? Are there glitches? Does the player keep dying? Is the inventory resetting? Is the whole world playing rickroll on an endless loop in the background? I know I'm going wild there, but "doesn't work" can literally mean million things.

So please, if it's a crash, provide the crash report. If it's a bug, provide the logs. Either way, list ALL the mods you have enabled with their versions + the version of forge. Then we can talk :)

commented

Newest forge for 1.12.2, only your mod SurvivalInc-1.2.8-2 and ElenaiDodge2-1.12.2-1.1.0 installed.
When i try to dodge, it just doesn't work. I press the button and nothing happens.
Dunno how to post logs, if theres no crash tho.

commented

Okay... I will try to look into it. But I'm still not sure what "try to doge" means.

commented

hahahah sorry i meant dodge. English is not my native language^^

commented

Oh okay that makes more sense. But I still need to check it on my own.

commented

Okay so after few hours of experimentation I have come to a conclusion that the problem lies on this line. This line registers event handler for every kind of event, and for some reason ElenaiDodge doesn't seem to like that very much. I will see what I can do to circumvent this weird restriction.

commented

Nice and thank you for your work.

commented

@hasuu UPDATE: I tested it, but I still do not see any problem. The ED's HUD renders properly with SurvivalInc HUD stacking enabled, even ED's HUD compatibility mode works. Can you post some steps to reproduce the thing you're describing (versus the expected outcome)?

commented

I know HUD works perfect, but have you tried dodging with alt, or double tapping with WASD keys?
If you want i can make YT vid.

commented

I mean, you can... But, it would be better if you'd just write down a list of steps what you have to do and then describe what should've happened vs what really happened.

It should look something like this:

  • I press
  • Then I walk forward
  • I press
  • should have happened, but happened instead.
commented

Okay I managed to get it to work. The details are provided in the javadoc and the commit message. In short, some hacky measures were implemented to generate event handler classes on demand instead of using one catch-all event handler. This should also improve performance quite a bit. I tested it with latest Elenai Dodge on 1.12.2 with default SurvivalInc config and all seemed to work well. Thus, I'm closing this.

commented

NICE! big thank you

commented

Update soon?

commented

I was planning to release it on 1st of September. But if you don't want to wait, see the wiki page about how to compile the bleeding edge version yourself.

commented

@hasuu in case you were still waiting, there's the new release in Curseforge