Techguns

Techguns

9M Downloads

Compatibility with Draconic evolution mod

Libright1558 opened this issue · 13 comments

commented

Techguns' weapons can bypass draconic evolution armor's shield which is supposed to block damage.

Is that intentional or just a Bug ?

Minecraft version : 1.12.2
Draconic evolution mod version : 1.12.2-2.3.20.333-universal
Techguns mod version : 2.0.1.2_1

commented

@MasterZero could You add the patched version of mod on curseforge, please?

commented

@dvdcorsair no, coz mod author do not give any permissions and "don't give a f*ck about your dildonic evolution"

commented

If mod A changes things and mod B changes thing the results are unpredictable. There is no specific code that somehow tries to bypass it. I would call it a "compatibility conflict". Very likely the damage bypass that techguns uses for the different damage types is incompatible with whatever draconic evolution does.

commented

Well I have a solution that works beautifully, however since in my case I am removing turrets from the mod (my pack has a better turret mod already) I don't need to handle cases where the getTrueSource is not a player (turrets) so my changes won't work with the mod as a whole. I might look into a complete solution for others to benefit from, but it's not a priority of mine.

commented

I was looking into this, the issue is that indeed mod A changes things mod B expects, except that in this case the bad actor, mod A, is TechGuns. In TGEventHandler you listen and cancel the OnLivingAttack event, with priority set to HIGH, an instead call your custom TGDamageSystem class. DE never gets to get activate it's shield, since its CustomArmorHandler listens for the OnPlayerAttacked event (which your mod cancels, and never refires as it should). I have been testing and it seems that within DamageSystem I can simply re-fire the event, once all the custom damagesystem is done evaluating its final damage amount, obviously checking for target and attacker being a player ect. Should be submitting a PR once I've thoroughly tested it.

commented

I would like to have a fix or workaround for this issues as well.. It's pretty annoying that people can kill me even if I have a full draconic armor.

commented

Seems I should go ahead and complete my patch to be more complete, as there are some other issues/suggestions I would like to implement anyways, might as well publish them for others to enjoy instead of hogging updates to my pack.

commented

I've got a modpack I've put together for some friends of mine, based off of FTB Revelations. I added in Techguns, and I'm wondering how precisely to get around the issue. I'd really appreciate it if you could share out your patch for it, even if the turrets get messed up along the way. It'd be incredibly appreciated by my friends and I.

commented

Ahh ya Ill have to get around to getting those changes posted, I had begun to rework the damage system, so I have to go back and just pull the changes for the armor tweaks

commented

My conundrum is this: I could PR the changes, but since they don't work with all aspects of the mod (turrets) it likely wont get accepted, plus PR's are a pain cuz of style nitpicking and slow acceptance. At the same time, I don't want to post my changes to my fork because players will go and download that version and will likely report issues in the wrong repo, potentially causing that repo's owner chasing down bugs that aren't even in their code.
It seems the best way would for me to release a compatibility mod for the few who really want it? It should be noted tho that I have not tested my changed with the shielding mechanics from this mods armor, and turrets also do not work because the server I am running has both of these disabled (other mods do them better).

commented
commented

I've build current version of techguns #(4e26523) with your changes @TerdyTheTerd. I really appreciate what you made, thank you. People who wants that fix can find it here removed

commented

I have better solution for damage system so it will handle damage as it should in both mods. Please, visit my repo who still searching for solution.