Fermentation vat
zefriwunfast opened this issue · 4 comments
Fermentations vat tps lag
Fermentation vat is causing tps lag, the observable mod show, one of them when in craft state use about of 13k μs/t.
To Reproduce
- Place the fermentation vat
- Put water in the fermentation vat
- Put the crafting ingredients in the vat
- Shift right click to close the vat
- And see the tps fly above the sky.
Expected behavior
Expected run smoothly and clear, but don't
Screenshots
System:
- Theurgy Version: 1.60
- OS: Windows 10
- Minecraft Version: 1.21.1
- Modpack Link and Version, or list of mods: All the mods 10, version 2.36, https://www.curseforge.com/minecraft/modpacks/all-the-mods-10/files/6201429
Additional context
I was trying to make a nether star farm with theurgy, challenging me to use another mods but the old ones, but the tps lag when the fermentation vat is woking, crashed my server, them I run a tps test with observable and see the vat is causing it.
@zefriwunfast could you run a spark report as well?
We have an older issue #230 where it was discovered that this is (usually) triggered by polymorph.
I made some changes to prevent adverse interactions, but a spark report with your current issue could help diagnose.
It is possible that we have to wait for a polymorph fix (or remove polymorph until there is a way to exempt theurgy vats from polymorph), but a spark report should tell me more
@klikli-dev sure, here it is the spark test.
@zefriwunfast thank you! Yeah it still seems to be related to polymorph. Could you try to run the server without polymorph to check if the same happens? (and if possible provide a spark report)
The vanilla recipe check caching (combined with some additions from patch 1.60 in theurgy) should reduce recipe lookups, but somehow that is not happening here. It would be good to know if it is still a polymorph incompatibility, or if it's a theurgy inherent problem