Tinkers' Steelworks (fork)

Tinkers' Steelworks (fork)

692k Downloads

Highoven doesn't use oredict Charcoal blocks

Arkandos opened this issue ยท 6 comments

commented

TSteelworks-1.7.10-1.0.5.jar

The highoven only accepts TSteelworks charcoal blocks as fuel and not other mods charcoalblocks.

commented

@Arkandos could you tell us which other mod provide charcoalblocks so we can check on both side?

commented

I've found the OreDictionnary entry for the charcoal block in TSteelworks
(https://github.com/wisthy/TinkersSteelworks/blob/master/src/main/java/tsteelworks/lib/ModsData.java#L111-L124)

and the way it is registered as a Fuel for HighOven.
(https://github.com/wisthy/TinkersSteelworks/blob/master/src/main/java/tsteelworks/common/core/TSRecipes.java#L61)

Based on that, normally, if we detect another mod has already provided a charcoal block, we don't create our own and use that one instead. So, the problem should occurs only when TS is loaded before Mekanism.

I'll rewrite the Fuel handling method to use the OreDictionary.

commented

Mekanism provides a charcoal block, and they are both oredictionaried

commented

ok,

So in mekanism we have https://github.com/aidancbrady/Mekanism/blob/5b4f154040caa4b39fa1919d32a63de66c61d99c/src/main/java/mekanism/common/Mekanism.java#L1131

But I don't see the OreDictionnary entry for charcoalBlock in TSteelworks. If you have it, it will help.

EDIT:
I've found it in Toops 1.6.4
https://github.com/Toops/TinkersSteelworks/blob/master/src/tsteelworks/common/TSContent.java#L248

It shouldn't be too hard to add it back in 1.7

commented

If it helps, this also occurs with Metallurgy 4 charcoal blocks.

commented

Wisthy's commit fixed it, closing