Tinkers' Steelworks (fork)

Tinkers' Steelworks (fork)

692k Downloads

ore berry bushes generate random berrys

Tsunayoshi opened this issue ยท 9 comments

commented

Hey,

My ig story :p
I have found a few copper bushes and raised them.
After harvesting them I have gotten random (alu, tin, iron) berries.
After a server restart I have gotten tin only from all copper bushes.
The latest restart make me get iron berries from all bushes.

I have posted this problem in as TConstruct issue and getting the answer, that TSteelworks caused this. SlimeKnights/TinkersConstruct#1085

I can confirm it, after I disabled the TSteelworks 1.7.10-1.0.6 version, it worked fine.

I have read your last post "I'd love to do more than fixes, but I'm pretty busy right now :(" - so I don't know if you have already been informed about this.

Thank you for your work and take all the time you need!

commented

I didn't know about this. It's quite an annoying bug so i'll take a minute to fix it, promise :3

commented

Oh my goodness that was quick ^^ Thank you very much.

commented

(it's not fixed yet though, so don't close the issue :p)

commented

Ah sorry, it looked like it was closed cause the link to #1085. Next time I will know it better :)

commented

In TC, the oreberries is managed there

https://github.com/SlimeKnights/TinkersConstruct/blob/master/src/main/java/tconstruct/world/blocks/OreberryBush.java#L191-L198

So far, I didn't find a place in TSteelworks where the behavior is overrided.

Well, I checked in more detail the TC version and I'm not 100% sure of how it works... I don't understand why it use "meta % 4 + this.itemMeta" as the meta for the new ItemStack. For me it should be either "meta % 4" or "this.itemMeta" but not both at the same time.

commented

Ok, after some explanations, now I get the logic at TC side.

Based on that, either the problem is linked with the meta being messed up with or the fields of the item.

One way or another, I don't see how it can come from TS so far. We don't even have a single reference to OreBerryBush.

@Tsunayoshi can you tell me if you are using a modpack and if yes which one? So I can try to reproduce it

@ephys Soit dit en passant, il semblerait que nous soyons concitoyens ^^

commented

Hey, sorry I am so late with my reaction. I will take out mods 1 by 1 to find out which mod cause this problem. What I can say now, your mod is ok. I have tested it with only tinkersC+extra utils. And the bushes are fine, so this here can be closed. And sorry for causing you troube!!! I will wirte you here which mod caused it, just let you know. I am really sorry taking your time for this...

commented

-.- of course it was/is gregtech... I think it is a unification problem.

commented

@Tsunayoshi thanks for the update