Universal Enchants

Universal Enchants

2M Downloads

[Bug]: Looting cannot be applied to swords with this mod

brisingraerowing opened this issue · 22 comments

commented

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.9

Notes (Required)

Current Behavior: Looting cannot be applied to swords
Expected Behavior: Looting can be applied to swords

  1. Install mod
  2. Try to apply looting to sword
  3. Looting cannot be applied

latest.log (Optional)

No response

commented

Please be more clear for the steps you tried to apply looting: what sword, anvil/enchanting table/enchant command.
Also share your .minecraft/config/universalenchants/looting.json file if possible.

I just tried on a fresh install and looting can be applied as expected.

commented

looting.json

It was a Diamond sword, though the file doesn't mention swords at all (that I saw)

commented

Delete the file and let it regenerate. Send that new file again please. It must include $minecraft:weapon for swords to work.

Also did you manually edit the file?

commented

No manual editing. I'll regen the file in a bit. Currently trying to debug a lag issue.

commented

Can you try this custom version please?
https://mega.nz/file/6ElRjRRY#-G2KiJsbzb4msyaeRAgrPk7wKPZHPfOFqZvBwJ65iaw

Ideally it should crash and be more clear about what is wrong, I need the crash report from that.

I looks like you have another mod that is trying to make tridents compatible with looting in an odd way. Do you have any idea what mod that might be?

commented

I have Apotheosis, which does that. I was suspecting a compat issue with it.

commented

The game did crash, but it was due to a different mod I updated earlier. Trying again with that reverted.

commented

And the game loaded normally. The JSON config files weren't generated, though.

commented

Can you just delete the whole universalenchants config folder? That will make it regenerate for sure. The send the new looting file.

commented

That's what I did, and the custom file didn't recreate it at all.

commented

Oh an did you join a world? I think the files only generate when entering a world.

commented

Can you send the latest.log from that launch?

commented

I just did a test with the KubeJS list_tag command, and the #minecraft:weapon tag doesn't even exist in the instance. Now to figure out why. I'm presuming that is the cause of the $null in the config.

commented

I figured that out a moment ago. I'll get the file in a moment. File Explorer is being stupid with locked folders / files again.

commented

looting.json / latest.log

Here's the config / log files. I don't see anything of particular use.

commented

$minecraft:weapon is not a tag. That link doesn’t seem to work.

commented

There was an extra character at the end of the URL for some reason. Try it now.

commented

This issue is becoming weirder and weirder, the last one should have really revealed something...

Here goes another one, both files again please and a crash report if one pops up:
https://mega.nz/file/PEtQzDyK#EbrPOoI1kdR1L0cNSgUB0BzPbHkTg1U4uPu3VXx5yAY

Also thanks a lot for helping with this!

commented

The crash happened before the looting JSON file was generated.

latest.log / Crash Report

commented

Finally, that explains it. You have some mod that enables looting for axes, that is conflicting here. Do you have an idea what that might be?

I‘ll work on a fix tomorrow.

commented

Ensorcellation does that.

commented

Should be fixed in the latest v4.2.10. Can you confirm that?