Universal Tweaks

Universal Tweaks

871k Downloads

Rare "stuck" game launch due to Incurable Potions tweak

xJon opened this issue ยท 6 comments

commented

Happens in a modpack environment in about 2-3% of launches, not sure why. Figured it's best to have it documented.
https://mclo.gs/4s8ZtYG

commented

After disabling Incurable Potions, it seemingly occurred again due to the Potion Amplifier fix: https://mclo.gs/q5dqX0f
But after disabling that too, it happened again with a bunch of Universal Tweaks features mentioned, as well as Thaumic Augmentation: https://mclo.gs/hs6dGl9#L382
Something weird is going on.

commented

Thaumic Augmentation is utilizing a bunch of direct ASM transformations which don't stack with both other ASM code modifications and mixins. Virtually endless possibilities of incompatibilities!

commented

Seems to happen in E2E:E as well Krutoy242/Enigmatica2Expert-Extended#355
Possibly some other mod transforming a related class using ASM and causing the crash. Particular mod/reason is unknown though.

commented

@ACGaming Thing is, this does not occur consistently on launch but only sometimes. Might be some weird race condition.

commented

Maybe try running with the java arg -Dmixin.dumpTargetOnFailure=true? When it crashes, this will dump the erroring class file to the folder ./.mixin.out, which you can upload here and maybe it might provide some insight. Try this with Incurable Potions on first.

commented

From some extensive testing, I believe this is caused by LoliASM's optimizeFMLRemapper feature - I can't reproduce the issues with B:optimizeFMLRemapper=false.