[Bug]firework rocket dosen't boost flying with elytra
1950694292 opened this issue · 5 comments
It is, thanks for the research! Since this was borrowed from VanillaFix, it‘s the same issue as DimensionalDevelopment/VanillaFix#138.
Can‘t imagine why this issue is related to the tweak, going to make it opt-in for now.
Tweaks: Performance, Fast World Loading seems to be the culprit.
Forge 14.23.5.2860
UT: 1.4.1
Great insight! Didn‘t know about this check, but it makes a lot of sense now.
The fix for this is easily conceivable: Making sure that the entity ID is never 0, similar to recent versions.
It looks like it has to do with this vanilla issue that was fixed in MC 1.14+ by changing the firework entity's BOOSTED_ENTITY_ID to use OptionalInt instead of Integer (implied by this issue), so it would take quite a bit of work to backport the fix. I assume the fast world loading tweak just makes the bug consistently reproducible because it probably ensures the player is the first entity loaded by not loading the initial chunks first.