VanillaTweaks [Fabric & Forge]

VanillaTweaks [Fabric & Forge]

8M Downloads

"Better Stone Tools" does not function when Quark is installed

HipHopHuman opened this issue ยท 0 comments

commented

Describe the bug (Required)
"Better Stone Tools" is completely broken when Quark is installed. Quark adds a config to allow variant cobblestone in the stone tools recipes, which overrides the behavior in VanillaTweaks to require regular stone. When this Quark config is set to false, VanillaTweaks forgets to re-enable the correct behavior.

To Reproduce (Required unless not known)
Steps to reproduce the behavior:

  1. Install Quark
  2. Install VanillaTweaks
  3. Install JEI
  4. In config/VanillaTweaks/Crafting.toml, ensure betterStoneTools is set to true
  5. In config/quark-common.toml, set "Better Stone Tool Crafting" to false
  6. Start the game
  7. Look at the JEI recipe for the stone pickaxe.

Log output/error (via. Hastebin)
I don't think a log is applicable to this issue. If it will help, say so and I'll provide it.

Expected behavior (Required)
I expected to see 1 recipe - that a stone pickaxe requires 3 stone. Instead, I saw 2 recipes, both for different variants of cobblestone.

Screenshots
image

Versions:(check log if you don't know)

  • Forge Version: 31.2.36
  • MC Version: 1.15.2
  • Mod Version: 1.15.2.1.5.30
  • JEI Version (if present) : 1.15.2-6.0.3.15

Additional context
The code introduced in this commit is not sufficient. It should not just check if Quark is loaded, but also if Quark's "Better Stone Tool Crafting" config is enabled. That, or the change should be reverted and users with the problem of duplicate recipes should be forwarded to CraftTweaker for disabling recipes.