Vintage Delight

Vintage Delight

1M Downloads

Crash with Turkish locale

Poopooracoocoo opened this issue · 0 comments

commented

Describe the bug
Crash with Turkish locale.

A user reported this in the Forge Discord server. The log is theirs.
Crash report https://gnomebot.dev/paste/mclogs/muJS1Aj
Log https://gnomebot.dev/paste/mclogs/INwAzBh#L628

Error: Exception caught during firing event: Block{minecraft:air} has property: position with invalidly named value: mıddle

You need to specify the locale when using toLowerCase and toUpperCase, which should be Locale.ROOT.

https://github.com/ribs498/VintageDelight-master/blob/master/src/main/java/net/ribs/vintagedelight/block/custom/VineNetBlock.java#L73

Notes
https://garygregory.wordpress.com/2015/11/03/java-lowercase-conversion-turkey/
http://www.i18nguy.com/unicode/turkish-i18n.html
https://haacked.com/archive/2012/07/05/turkish-i-problem-and-why-you-should-care.aspx/

Workaround for users
Add the following JVM arguments: -Duser.language=en -Duser.region=US
You can change the language in Minecraft after doing this.

atp i've reported issues like this so many times that if you want more info you can just do a search for just my issues on this for more info. very trivial fix