MineFactory Reloaded + Tinkers' Construct + WAWLA Crash
spacerecycler opened this issue ยท 10 comments
WAWLA Version: 1.0.3
Minecraft Version: 1.7.10
Forge Version: 10.13.0.1207
OS: Windows 7
JVM: Oracle 1.8.0_11 - 64bit
I'm running into a crash with MineFactoryReloaded and Tinkers' Construct installed with WAWLA. Steps to reproduce are below.
- Install WAWLA, Waila, CodeChickenCore, CoFH Core, Mantle, MineFactory Reloaded, NotEnoughItems, Thermal Foundation, Tinkers' Construct, CodeChickenLib
- Versions are in Gist linked below
- Start Minecraft and run a new World
- Go into Creative and pull out a Harvester block from MineFactory Reloaded
- Place this block in the world, the Game will crash and I believe it's trying to load the Waila/WAWLA HUD info
I've created a Gist here https://gist.github.com/spacerecycler/fe4b3c529153acdbe82b which has the versions of the mods and the MultiMC output. The OpenEye link for this is here http://openeye.openmods.info/crashes/49063465e63f80c4da7dc047eae32e6b but did not update the mods when I took the rest of them out of my configuration. I have a separate bug open for this OpenEye issue.
Thank you for submitting this issue, it is very helpful. I had initially fixed this issue in 1.0.3 however I believe there may be an issue with the newer java version. I have compiled a version of the mod that contains some extra checks to help prevent this issue, could you please try again with this new version and report the results back to me?
https://dl.dropboxusercontent.com/u/38575752/Wawla-TestFix.jar
Here's another Gist https://gist.github.com/spacerecycler/2c4f6492539054119f0a with two logs from both 1.7 and 1.8 versions of the JDK with that test version. If you want I can also test with Java 1.6 but I don't know if other mods require 1.7. I also had another crash stored to the server for OpenEye here http://openeye.openmods.info/crashes/22cf57b28c9cf60b01d9c823603c9811, I guess because I was using Java 1.7. Let me know if you want me to test with a different mod version, I think NEI has later versions out but that's the only ones I know of.
Yeah I put that TestFix jar in my mods directory and disabled the release version
That is interesting, this error "shouldn't" be possible with that last jar. I have created a second version of the mod that has a few more checks, if this jar fails I believe the error may be within Waila and not Wawla. If the new jar does not work let me know so I can dig around with Waila. If that is the case you can go into the configuration file and disable the landmine feature for now.
https://dl.dropboxusercontent.com/u/38575752/Wawla-TestFix2.jar
Hmm, I downloaded that new jar and tried it with every other MFR machine and then the Harvester and Minecraft only crashed on the Harvester. This may be a bug there or just some interaction between WAWLA, Waila and MFR. I can try more of the blocks and maybe even more blocks from the rest of the mods but I'm not sure I have the time just now ๐ญ. Also it's complicated by the fact the MFR code is delivered obfuscated but I don't think I can get around that. Here's the link to the new OpenEye crash http://openeye.openmods.info/crashes/a08b06331bc3e17bfc88481f29de680f. If you need the logs I can generate them I missed capturing them this time around.
I tested again this morning and every other block works for MFR, Thermal Foundation, and Tinkers' Construct. I found the right repository on Github now and it looks like it may be possible for the _treeManager to be null in the MFR code when it is writing NBT data https://github.com/skyboy/MineFactoryReloaded/blob/master/src/powercrystals/minefactoryreloaded/tile/machine/TileEntityHarvester.java#L353. Let me know if you want me to file this bug there and reference this bug.
When it comes to things like this there are a few places where the bug can be patched. Right now it seems that when Waila so much as checks to see if the nbt is null, it gives a null pointer and exits. ProfMobius should add a check in Waila to fix this. That being said the other mod should be more careful how it distributes its data. It would be preferable if we got this patched on all ends :)
Should be resolved with 1.0.5 please test and get back to me. (going to auto close issue on 31st)