Witchery: Companion

Witchery: Companion

11.2k Downloads

[Witchery Bug] Infinite loop with Cubic Chunks

DarianLStephens opened this issue ยท 7 comments

commented

Description
Witchery: Resurrected backports the new villager sleeping system. Unfortunately, this seems to want to scan a chunk's worth of a column of blocks. With Cubic Chunks, a column is infinite.
I'm not certain how this could be resolved, barring perhaps adding a limit for it to abort or disabling the system altogether?
Or make villagers only scan a certain height radius relative to them, if at all possible, to preserve cubic functionality?

When I tried with older versions of WR before this was implemented, all other features seemed to work fine. Waystones would go to and from the extended Y coordinates, altars worked, rituals, it all seemed fine.

Context
Environment
[X] The issue is present in Single-Player
[X] The issue is present in Multi-Player
Other mods
[ ] The issue is present with just Forge and Witchery: Resurrected
[X] The issue is present when the following mods are installed: (please list the minimum amount of mods required to reproduce the issue. The less mods, the quicker the issue can be reproduced and solved)
Forge
Witchery: Resurrected
Cubic Chunks

Steps to Reproduce
The more detailed is provided, the easier will be to reproduce and analyze the issue, thus more chances to solve it

  1. Make a world with some Cubic type
  2. Load it
  3. Observe as the game may render for a couple seconds, then hang indefinitely, possibly with an infinite slow climb of RAM usage

Crash Report / logs
No crash report, I'm afraid, as the game never actually crashes. I've had it running for upwards of an hour in the state it was, with no recovery or end.

commented

What version of Forge and Cubic Chunks are you using? I can't even get into a world due to a crash with only forge and CC

commented

CubicChunks-1.12.2-0.0.1208.0, Forge 14.23.5.2860

commented

Nope. Villager sleeping is a mechanic inside the villager AI introduced with Minecraft 1.14 and backported to 1.12 by W:R. This tweak disables the Witchery AI, so villager behavior returns to Vanilla 1.12. Making villagers place their own beds would have no effect as they wouldn't be able to sleep anyway

commented

Starting from version 0.33.0-beta, a new tweak "Villager - Tweak Remove Backported AI" in "Entity Tweaks" section of config file is available, disabled by default. When enabled, it will remove the new AIs that Witchery adds to villagers, and that should solve disable the part of code that causes this issue

commented

Oh, you responded to this already, awesome!
I forgot I made this issue, to be honest.

Does it also restore the original villager sleeping behaviour from earlier versions of Witchery: Resurrected? Where they just kinda spawn their own bed as part of their model?

commented

I'm talking about the thing from the original Witchery, where villagers will still go home and lie down in a bed, which is part of their entity model, and stop moving, regenerating their blood.
It was also a feature in Witchery: Resurrected, until version 0.5.2, where it was replaced with the current system.