Temporal Sampling causes black visual glitches underwater
nickesc opened this issue · 3 comments
When using any Temporal Sampling options (Denoise, TAA, or Sharp TAA), if the player goes underwater or emerges from underwater the view will be obscured by large, black visual glitches (see attached recording for details). These glitches are cleared from the view by looking away from them. Appears to only occur when going underwater if the player submerges slowly, and not if they jump in quickly. Turning off Temporal Sampling prevents the glitches.
TAA-black-shader-bug-720p-20fps.mp4
Environment:
- OS:
macOS 14.7 - Processor:
M1 Max - Minecraft Version:
1.21.4 - Fabric Loader Version:
0.16.9 - MakeUpUltraFast Version:
9.1
Recording shows use with a number of mods, but the behavior is the same with only these mods installed:
fabric-api-0.111.0+1.21.4.jariris-fabric-1.8.4+mc1.21.4.jarsodium-fabric-0.6.3+mc1.21.4.jar
Shader pack settings in the recording are mostly default for the High profile -- notably, the Black Entity BUGFIX is toggled on. It has also been tested with completely default settings and displays the same behavior.
I understand. It's a specific problem with a certain type of hardware, so it's a bit difficult for me to verify if the proposed solution actually fixes or mitigates the problem.
In the "develop" branch of the repository, the latest commit has a possible solution implemented, but I would need you to verify if it actually works.
What you should do is clone the repository and switch to the most current "develop" branch and verify it yourself.
If you have any trouble doing this, you can ask me.
The version in the develop branch seems to have fixed it. Tested using the Extreme+ preset and each of the Temporal Sampling options; all 3 options behave as expected. No more black visual glitches that obscure the view until looking away. See attached video for proof of expected behavior.