AdiBags

AdiBags

8M Downloads

Crafting Reagents Not Filtering Properly.

nancikennedy opened this issue ยท 7 comments

commented

The recent patch has caused AdiBags to dump all the crafting reagents into an "Item Enhancement" filter. This then causes the filter by sub-category to also fail, leaving them all in one huge section. I've included a screen snip to illustrate. This was taken when AdiBags was the only addon enabled, with all the standard filters (except Tracking New) where enabled.

bag

commented

This bothered me enough to dig into it; it looks like the WOW api is now returning "Item Enhancement!" instead of Tradeskill or Trade Goods when GetItemID is run on a trade good item (Informant from the Auctioneer suite is affected by the same issue).
For a temp fix in Adibags, you can edit DefaultFilters.lua, line 51 to say
local TRADESKILL = "Item Enhancement!"
and enable subcategories for Item Enhancement! in the Adibags item category options.
This temp fix will obviously break if/when Bliz fixes the GetItemID return value for trade goods.

commented

Hrm, I tried that trick and all it did was change the name of the option in the config window. It still doesn't seperate them by sub-category...but it's pretty much a given that that is because of Blizz's error. Rolling restarts tomorrow...betting they caught it and it's now fixed. Thanks for the efforts though. :)

commented

Maybe it's because I had updated to the alpha version on curse prior to digging into the lua? adibags

commented

Will try that...

commented

Still didn't work for me. Weird. Running v1.9.2-1-g0aac3e8, with only AdiBags enabled. Made sure to completely exit wow before making the change to the lua file. Screenshot shows the result for me.
capture2
capture

commented

Blizzard messed up the returns in the last patch as well. I'm surprised they haven't hotfixed it yet.

@nancikennedy
You forgot the exclamation point.

commented

/snort
Now it works. Thanks for all the help. :)