NOTE: Bugs can sometimes be caused by conflicts with other addons. Please disable all other addons and try to reproduce your issue. You must answer below that you have tried disabling all your addons before this bug is accepted. If you have not tried disabling all your addons, your bug will be closed.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'open bag'
2. See alot of recently added items (like 30-40)
3. Click on 'reset recently added items'
4. open container, or manually restack items (even had it yesterday after just looting an item)
5. see alot of recently added items (like 30-40)

Expected behavior
like normal, just see the actual recent items, not almost the entire bagspace up in recently added

Screenshots
If applicable, add screenshots to help explain your problem.
normal view

recent items distorted:

World of Warcraft Release and Version (Retail 9.2.7, etc)

• Retail 9.2.7, etc, etc

AdiBags Version

• v1.9.35

Have you tried disabling all your other addons to ensure only this addon causes the issue?

• No, however i did go back to 1.9.34 which does not have the issue.

Additional context
Add any other context about the problem here.

• it happens all the time... like if i loot something new, open a container.
• if i reset the recently added, and reopen my bags its fine, however first time i loot/change a stack/open a container its back.
• i dont move alot of items in/out my bags
• like stated above, it was easy to replicate

Thanks for the report!

Can you provide some more information as to what you were doing just before this happens, and some more in-depth explanation as to your experience here? Specifically:

• How often does this happen?
• When you recent recently added items, does the issue reappear the next time you open your bag?
• If not, when does the issue reappear?
• Do you move a mass quantity of items in and out of your bags?
• Can you think of any way to consistently trigger this?

Thanks!

I spent about an hour trying to reproduce this in every way I could think of, and have not been able to. This was a bug in .33, rolled back in .34, and forward with a bug fix in .35.

I'll keep this bug open so that others can chime in. My initial thought was it's related to #629, but I'm not sure that's the case. I'll continue to try to reproduce this to the best of my ability.

I'm experiencing the same thing in 1.9.35. I dropped back to .34.

I see this behavior when I've just opened and received mail items. A multitude of objects appear in the recent items list and actually leave gaps in the area below -- like they'd been moved there and visual space was not reclaimed.

Okay, interesting, I didn't try mail. Let me see if I can reproduce it. Do you keep your bags open when you get all the items from the mail?

Yes, mail opens my bags and I don't close the bags.

And items just magically start shuffling into recent items from the categories under them? Do the new items you get from the mail also show up in recent items?

Okay, I can't reproduce this, but I have a small change that I think might fix it, looking at the logic. Can one of you who can reproduce it, install .35, make it break for you, then edit widgets/ContainerFrame.lua, on line 665,

change it from:

sameItem = prevGUID == guid

to:

sameItem = prevGUID == guid and not (prevGUID == "" or guid == "")

It's alright if you don't want to do this, but it would save me a whole lot of trouble in pushing a new version and forcing everyone to update again.

Thanks!

Push has been fixed and should show up on curse within the hour. I can no longer reproduce the issue.

Silly question, but did you reload your UI before you tried again, via /reload?

Alright, one last test -- can you change the line to:

sameItem = (prevGUID == guid and not (prevGUID == "" or guid == "")) or addon.IsSameLinkButLevel(slotData.link, link)

and then do /reload, and see if that fixes it? If this isn't it, then I do think it's related to #629, and I'll have to fix that first.

I just got it to reproduce reliably! I don't think I've ever been so happy to actually hit a bug in a long time. Give me a few and I'll debug -- thanks for your help, no need to make any more changes. Will report back with a solid fix (likely in version .36).

Alright, quick update for everyone. I've figured out what's going on -- the bug has always been here in terms of pure logic, it just hasn't been exposed up until now because of the way we handled the bug. The fix may take a day or so to get out the door.

Thanks for everyone's help!

As a confirmation, updating to .36 solved the issue! top notch work my friend, thanks!