AdiBags

AdiBags

10M Downloads

Complete list of 17 error reports on login

Kream opened this issue · 105 comments

commented

Addon Version

1.9.46

World of Warcraft Version

Retail

Describe the bug

When logging in, the following are the error reports generated:

BUG 01
1x Interface/AddOns/AdiBags/core/Core.lua:185: attempt to index field 'anchor' (a nil value)
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:185: in function <Interface/AddOns/AdiBags/core/Core.lua:184>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:558: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:551>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:119: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:59>
[string "=(tail call)"]: ?


BUG 02
1x Interface/AddOns/AdiBags/core/Utility.lua:334: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/core/Utility.lua"]:334: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 03
1x Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:783: Usage: GetItemClassInfo(itemClassID)
[string "=[C]"]: in function `GetItemClassInfo'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:783: in main chunk

Locals:
(*temporary) = nil

BUG 04
1x Interface/AddOns/AdiBags/modules/FilterOverride.lua:57: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/modules/FilterOverride.lua"]:57: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 05
1x Interface/AddOns/AdiBags/modules/Junk.lua:50: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/modules/Junk.lua"]:50: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 06
1x Interface/AddOns/AdiBags/core/DefaultFilters.lua:44: Usage: GetItemClassInfo(itemClassID)
[string "=[C]"]: in function `GetItemClassInfo'
[string "@Interface/AddOns/AdiBags/core/DefaultFilters.lua"]:44: in function `SetupDefaultFilters'
[string "@Interface/AddOns/AdiBags/core/Filters.lua"]:65: in function `InitializeFilters'
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:97: in function <Interface/AddOns/AdiBags/core/Core.lua:81>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:494: in function `InitializeAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:619: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>



BUG 07
1x Interface/AddOns/AdiBags/core/Layout.lua:128: attempt to index field 'anchor' (a nil value)
[string "@Interface/AddOns/AdiBags/core/Layout.lua"]:128: in function `UpdatePositionMode'
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:179: in function <Interface/AddOns/AdiBags/core/Core.lua:122>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>


BUG 08
1x Interface/AddOns/AdiBags/modules/TooltipInfo.lua:55: GameTooltip doesn't have a "OnTooltipSetItem" script
[string "=[C]"]: in function `HookScript'
[string "@Interface/AddOns/AdiBags/modules/TooltipInfo.lua"]:55: in function <Interface/AddOns/AdiBags/modules/TooltipInfo.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

BUG 09
1x Interface/AddOns/AdiBags/core/Utility.lua:1 (null)

BUG 10
1x Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1 (null)


BUG 11
1x Interface/AddOns/AdiBags/modules/FilterOverride.lua:1 (null)

BUG 12
1x Interface/AddOns/AdiBags/modules/Junk.lua:1 (null)

BUG 13
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/core/Utility.lua:1 (null)

BUG 14
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1 (null)

BUG 15
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/modules/FilterOverride.lua:1 (null)

BUG 16
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/modules/Junk.lua:1 (null)

BUG 17
2x Interface/AddOns/AdiBags/modules/DataSource.lua:123: attempt to call upvalue 'GetContainerNumSlots' (a nil value)
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:123: in function <Interface/AddOns/AdiBags/modules/DataSource.lua:119>
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:152: in function `Update'
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:78: in function <Interface/AddOns/AdiBags/modules/DataSource.lua:70>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

Steps to reproduce

Log in with Adibags enabled.

Verification

  • I have disabled all other addons and made sure this bug is triggered only with AdiBags enabled
commented

@MleveK URGENT: on your last version v5, its auto generating upon entry a storm-battered reagent pouch into the first bank slot in game. I disabled all addons but this one and it still does it, When disabling adi, it no longer does it. It made 2 pouches for me on a new character and I had not even visited the pre-event vendor yet.

commented

Hi everyone,

I'm back in town and in front of my gaming PC. I'll be working on this through out the day today and should have something in place and officially released soon.

@Wraiven Please refrain from using words like "URGENT" to notify the volunteers on this project.

Thanks!

commented

Every WoW quest insists that I do it right away. As when the boy cried wolf, my first instinct when someone insists on urgency is to drag my feet, close the game, go do something else. I don't think the people writing these things realize how much of a disincentive that is.

commented

Hi everyone,

I'm back in town and in front of my gaming PC. I'll be working on this through out the day today and should have something in place and officially released soon.

@Wraiven Please refrain from using words like "URGENT" to notify the volunteers on this project.

Thanks!

ahh I do apologize for that. Although I knew he was a volunteer, it slipped my mind when posting. Again I apologize!!

commented

A new stable release has been pushed to all channels (curse, github releases, etc). Note, this new update does not add support for all the new features in DF, including the new bag type. This release is meant to stabilize the playing experience so the bag "just works" as it did pre-DF. This gives users a safe-ish known-good-version that works with DF as we retool for DF's new additions.

Thanks everyone. I'll keep this bug open for a while longer.

commented

Just wanted to say that this addon is amazing and thank you SO much Cidan and all the volunteers and the other addon devs who have worked so hard to update and fix AdiBags. You're all wonderful people and I hope you all win the lottery someday. <3 Am thrilled to be getting back into it bc as of 30 seconds ago it's updated... this is the one addon I can't play without! Thanks again!

commented

storm-battered reagent pouch

Thanks for the hard work @Cidan .

commented

I'm going to have to play the pre-patch event for a bit to get the new bag so I can test against it -- not even sure what to do, so, here we go.

commented

I'm going to have to play the pre-patch event for a bit to get the new bag so I can test against it -- not even sure what to do, so, here we go.

Thank you @Cidan for all your hard work.

commented

Sorry I was out for a few days. Glad you're back @Cidan and sorry I didn't get a chance to respond to your message.
If you have any questions or need anything let me know.
I'll leave it in your hands now.

commented

No worries @MleveK -- thank you for everything. I'll start shipping some of your fixes soon. :)

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue. I can't figure out the difference between these 2 use cases and the kind of error

I fixed this issue by reseting the profile few times in Adibags' option window.

I am still having this issue even with the updated build. I reset profiles, removed all addons, cleared WTF and the addon in the addons folder, installed fresh. The addon works, its just every time I sell something the window closes. I am not getting any errors in bug sack or I would attach them

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue. I can't figure out the difference between these 2 use cases and the kind of error

I fixed this issue by reseting the profile few times in Adibags' option window.

I am still having this issue even with the updated build. I reset profiles, removed all addons, cleared WTF and the addon in the addons folder, installed fresh. The addon works, its just every time I sell something the window closes. I am not getting any errors in bug sack or I would attach them

Hey, on another it isse someone found that it seems to be related to a tooltip error with the profession update, see if it solves it for you #800 (comment)

commented

The 5.1 version that was posted above works fine for me, but the one that's pushed out to CurseForge (v1.9.47-nolib) does not work for me. The "release" version does not open a bank window at all. What I do to get it to work is install the "release" version from CurseForge and then copy the v5.1 version over it.

commented

@Ashenblue I've just released .48 which contains initial support for the Reagent bag and some general fixes.

commented

Yeah list seems pretty complete to me.

commented

I'm sure @Cidan is aware, have some patience...

commented

Thx for the Fix it works perfectly fine!

Way more stable than the things i was trying to do !

commented

Thank you for the update!
Much appreciated.

commented

@MleveK Thank you for the update. The biggest issue I have is when I use the option "Merge stackables items including incompletes stacks", the stack size number is wrong for any items.

commented

Yes, I know that was adding a confirmation not a rush on it. Nothing implied that at all.

commented

I've Repaired most of the issues. There might still be problems, let me know and I can look into it. First, make sure it's not an addon interfering.
I had to remove a few functionalities.
AdiBagsV2.zip

commented

MleveK, thanks so much! You are a prince amongst men, or a princess amongst women, or a dracthyr thing amongst drakonids.

commented

Download V2 I just posted and fixed that
(Edited in the previous post so V1 isn't downloaded by mistake)

commented

Seems good so far, no more errors and seems to be working

commented

Think you left a debug print statement in it though

commented

Cool thanks

commented

OMG ty, the only thing i could see was a line with the currencies, my bags are back now ty

commented

I downloaded V2 and it's working now, thanks for updating it. The only issue I can find is that when you use a consumable (e.g. enchantment scroll, food, flask, soul ash/soul cinder) by right clicking on it from the Adibags view it does not reduce the quantity until you close and reopen the bag.

commented

I downloaded V2 and it's working now, thanks for updating it. The only issue I can find is that when you use a consumable (e.g. enchantment scroll, food, flask, soul ash/soul cinder) by right clicking on it from the Adibags view it does not reduce the quantity until you close and reopen the bag.

For me when using any consumable or equip anything it closes the bag window. No errors occur thought.

commented

Thanks for the quick fix, now I can at least play the game while waiting for the update! <3

commented

V3
I don't mind updating this, It's one of my favorite addons, I had it off because of the errors and couldn't find a piece of gear in my bags for 10 minutes, I got frustrated and decided to see if I could temporarily fix it anyways.

@ozgod1 - I fixed Using a consumable, the window should now update.
@juntereiner - I fixed Stackable including incomplete stacks not showing the correct count.

@Werneq - I'm not sure why the window closes when you click on something. I don't have that issue. Try with just this addon(disable all others), and if it persists, I'm assuming it's an option somewhere that I'm not using that's triggering it. Try switching to the default profile and see if it resolves it. if you can pinpoint the option causing this, I don't mind taking a look at it.

Note: I did notice that when moving an item the border color doesn't update correctly. Not crucial but if I have time I'll take a look. If more issues come up that are critical, let me know.

I'm sorry if some of the errors are missed, I'm not trying to make the addon back to 100%, just workable for now.

AdiBagsV3.zip

commented

much appreciated for the bandaid version! at this point I'm mostly having trouble with pretty much ALL of the third party adibags modules i have downloaded lol

I hope there will eventually be a fix for all these SetBagItem errors and that the old (perhaps abandoned) ones can be repaired too

commented

No worries, you are doing a great job. I'll try a fresh interface folder when I can and update here after.
TYSM for your work, we love adibags

commented

Just FYI: With the v3 fix, the count of free slots seems missing, and the search box doesn't highlight.

Thanks for updating it.

commented

When will v3 be in CurseForge?

commented

Hi, sorry for asking but I'm not used to manually updating my addons. Is there any change it'll be updated on curseforge soon?

commented

Hi everyone, official maintainer here.

Unfortunately, I am out of town on a work trip on the exact week that this new patch hit :|

Blizzard decided to make sweeping bag API changes in this patch version, but did not provide early-access to all addon authors, making it all-but-certain bag addons would break upon release of this patch. As soon as I'm back home Sunday night PST, I will start working on an official fix for AdiBags.

I'm very, very sorry to all our users that AdiBags is broken this week, and I take full responsibility here. Sadly, my work trip was unavoidable. Expect a full update next week.

Thanks!

commented

Hi everyone, official maintainer here.

Unfortunately, I am out of town on a work trip on the exact week that this new patch hit :|

Blizzard decided to make sweeping bag API changes in this patch version, but did not provide early-access to all addon authors, making it all-but-certain bag addons would break upon release of this patch. As soon as I'm back home Sunday night PST, I will start working on an official fix for AdiBags.

I'm very, very sorry to all our users that AdiBags is broken this week, and I take full responsibility here. Sadly, my work trip was unavoidable. Expect a full update next week.

Thanks!

RL takes precedence, Thank you for a great Addon that gave Blizzard the idea to make their own, your is still superior!

commented

@MleveK thank you for your efforts, it's certainly workable. The issues are just minor things that don't prevent usage, but I thought to have them reported. Appreciate your work.

@Cidan thank you for your efforts in maintaining the best bag addon in WoW!

commented
commented

@MleveK can you create a pull request for your changes?
@Cidan I know you are absent, but can you speed up doing the code review for @MleveK when he creates PR?

commented

@set4812 please chill out. Make do with @MleveK 's zip file like the rest of us until Cidan has time.

commented

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

commented

@MleveK Very strange, I tried with only adibags and the window still closes, after fiddling on configs and reload a couple times it stop. I have zero problems right now.

Sorry I could not find the source of this bug, if I find it again I'll update here. For now thanks for the help.

commented

Two more to fix: UseContainerItem in Junk.lua and BankSwitcher.lua is now in C_Container.

commented

yay ty @MleveK for a quick fix till Cidan gets back.

@Cidan do you plan on adding the slot for the new reagent bag? As of now no way to access that slot or open it

commented

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

@set4812 You realize that this is not @Cidan's job? He does this for free for the community? This demand is disgusting.

commented

I'm glad I looked in here. Thanks for the quick patch @MleveK , and thanks for the wonderful work on this addon in general @Cidan. Being thrown back into the default bag UI and staring at a giant wall of items I can't make visual sense of has renewed my appreciation for everything this addon does for me.

commented

I'm working on some more fixes, I noticed a few errors with the Bank (@SpareSimian mentioned), and the Free Slots not showing the actual count and I'll see what I can do with the Reagent Bag spot(No guarantees lol).
Will post a new version later today.

I'll also see what I can do for Git but in the end, that's @Cidan to decide.

Also @Cidan You're more than welcome to use my code to get you moving forward when you have a chance to update it all. It's not perfect but should save you some time. You can always reach out if you need anything from me.

commented

I'm working on some more fixes, I noticed a few errors with the Bank (@SpareSimian mentioned), and the Free Slots not showing the actual count and I'll see what I can do with the Reagent Bag spot(No guarantees lol). Will post a new version later today.

I'll also see what I can do for Git but in the end, that's @Cidan to decide.

Also @Cidan You're more than welcome to use my code to get you moving forward when you have a chance to update it all. It's not perfect but should save you some time. You can always reach out if you need anything from me.

Just wanted to say thanks for the quick fix until the author comes back!
Only things that really needed updating to your V3 were:

-- Container constants
ITEM_INVENTORY_BANK_BAG_OFFSET	= 4; -- Number of bags before the first bank bag
CONTAINER_BAG_OFFSET = 30; -- Used for PutItemInBag

BACKPACK_CONTAINER = Enum.BagIndex.Backpack;
BANK_CONTAINER = Enum.BagIndex.Bank;
BANK_CONTAINER_INVENTORY_OFFSET = 39; -- Used for PickupInventoryItem
REAGENTBANK_CONTAINER = Enum.BagIndex.Reagentbank;

NUM_BAG_SLOTS = Constants.InventoryConstants.NumBagSlots;
NUM_REAGENTBAG_SLOTS = Constants.InventoryConstants.NumReagentBagSlots;
NUM_TOTAL_EQUIPPED_BAG_SLOTS = NUM_BAG_SLOTS + NUM_REAGENTBAG_SLOTS;
NUM_BANKGENERIC_SLOTS = Constants.InventoryConstants.NumGenericBankSlots;
NUM_BANKBAGSLOTS = Constants.InventoryConstants.NumBankBagSlots;

Edit:
Also a UseContainerItem = C_Container.UseContainerItem

commented

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

@set4812 You realize that this is not @Cidan's job? He does this for free for the community? This demand is disgusting.

I don't know if you read my first statement and understood it.
@Cidan is the maintainer, he can only merge changes, but he is absent until the end of the week. I understand his absent and that he can't spend time on addon fixes.
@MleveK is doing a great job at the moment, but you get patches in the form of a ZIP, which is not an official build. That's why I suggested a pull request for MleveK to do, then @Cidan can read the code in his free time and click merge. It will reduce the time his job on the project
I didn't force anyone to do it.

commented

@Cidan @MleveK
I opened PR #786 which addresses errors since the 10.0.2 update. Will be helpful if you can review it

commented

I appreciate the passion here everyone -- really, it's great to be a part of something that so many people find so useful. While I do understand the desire to see an official fix come out the door, I can't reasonably test or review changes in any meaningful way while I'm traveling. Specifically, all changes need to work across all product lines for WoW, i.e. retail, wrath, classic, etc, and I have no way to verify all the weird corner cases work before putting out a release.

Please feel free to keep creating patches, PR's, and suggesting changes, as they are most welcome, however nothing will be merged until I am back in front of my gaming rig at the end of the weekend.

Thank you everyone!

commented

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

commented

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

It's slightly more complicated than that, as

  1. We need to account for this change only in retail
  2. Some of the return values have also changed (i.e. tables instead of multiple value returns)

My current line of thought (I haven't looked at the PR's) is to just redefine the globals with functions that unpack tables using the new API. This minimizes the amount of code locations that need to change. There are also some other fixes in general I have sitting in a branch, i.e. the undocumented bank offset change, reagent bag, etc, that need to be applied.

commented

Ok, that makes sense. Patching in C_Container for the sorting methods lets me continue using the addon in Retail. I can imagine hat a pain it will be if the Wrath engine doesn't use the same namespacing changes. You have my sympathy! Indirection through an adapter function does sound like the best solution.

commented

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

It's slightly more complicated than that, as

  1. We need to account for this change only in retail
  2. Some of the return values have also changed (i.e. tables instead of multiple value returns)

My current line of thought (I haven't looked at the PR's) is to just redefine the globals with functions that unpack tables using the new API. This minimizes the amount of code locations that need to change. There are also some other fixes in general I have sitting in a branch, i.e. the undocumented bank offset change, reagent bag, etc, that need to be applied.

I kind of tried to do that ..... but i'm not really confident in my lua skills as i'm originally C developper :)

commented

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

Then they will have to learn, like it was 15+ years ago

commented

Hey All, see attached V4.

  • Fixed Free Slot Count
  • Added Reagent Bag Slot.
  • Added Separate Free Space for Reagent.
  • Bank bag fixes
  • Converted most of the changes to work for Classic+Wrath. (Not fully tested)

I will submit a PR tomorrow and will link it here for future pushes.
Enjoy!!

AdiBagsV4.zip

commented

@MleveK thanks bunches for your good work. It's nice having my bag all sorted again 👍

commented

@MleveK Thank you so much for this. I just wanted to note that v4 appears to have a conflict with Pawn. Any time I opened my bags, I got this:

50x Interface/AddOns/Pawn/Pawn.lua:422: attempt to call global 'GetContainerItemInfo' (a nil value)
[string "@Interface/AddOns/Pawn/Pawn.lua"]:422: in function PawnIsContainerItemAnUpgrade' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:417: in function UpdateUpgradeIcon'
[string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:345: in function Update' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:317: in function FullUpdate'
[string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:281: in function <Interface/AddOns/AdiBags/widgets/ItemButton.lua:269>
[string "=[C]"]: in function Show' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1066: in function PrepareSections'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1187: in function `FullUpdate'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:619: in function <Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:605>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/core/Utility.lua"]:100: in function <Interface/AddOns/AdiBags/core/Utility.lua:92>
[string "@Interface/AddOns/AdiBags/widgets/LayeredRegion.lua"]:119: in function <Interface/AddOns/AdiBags/widgets/LayeredRegion.lua:108>

Locals:
bagID = 2
slot = 1
(*temporary) = nil
(*temporary) = 2
(*temporary) = 1
(*temporary) = "attempt to call global 'GetContainerItemInfo' (a nil value)"

I've disabled Pawn and it's working perfectly now.

commented

@Jokinen86 Pawn just did an update.
I had initially turned off the feature but figured it would be fixed by now so turned it on in V4.
If there's still an issue I'll check it tomorrow.

commented

It seems to be working OK with the latest Pawn (from ≈2 hours ago) for me (no errors at least), except either AdiBags or Pawn spam my chat pane with a ton of nil, nil when I open my bags if both are enabled.

commented

someone leave a print() somewhere?

commented

Can confirm the nil, nil print bug every time bags are open with latest pawn.

thanks for the community updates!

commented

See my PR here
#790
From here the addon is fairly in good shape, I have not tested it all in Wrath\Classic yet.

Pawn is paused for now, the nil nil is from their side. It was posted on their curseforge from a user with bagnon.

I've attached my final V5 version as not everyone is familiar with downloading files from Github.
Any future changes will only be done through that PR.

AdiBagsV5.zip

commented

See my PR here #790 From here the addon is fairly in good shape, I have not tested it all in Wrath\Classic yet.

Pawn is paused for now, the nil nil is from their side. It was posted on their curseforge from a user with bagnon.

I've attached my final V5 version as not everyone is familiar with downloading files from Github. Any future changes will only be done through that PR.

AdiBagsV5.zip

Thank you!

commented

I love this addon precisely for the reason that made @MleveK want to update it. So i just want toi thank you @MleveK for this fix and also a big special thanks to @Cidan for keeping this great addon going. We are incredibly happy and thankful for your effort and work.

commented

I know this falls out of peoples remit here on this github, but can anyone competent make this work?

https://www.curseforge.com/wow/addons/adibags-boe-boa

I'm having a hard time going through all my banks and alts not having BoE's seperate. Thank you <3

commented

Got these 2 now after v5:

[1]
Message: Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1116: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: AdiBagsSection5:SetPoint.
Time: Fri Nov 18 14:40:33 2022
Count: 5
Stack: Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1116: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: AdiBagsSection5:SetPoint.
[string "=[C]"]: ?
[string "=[C]"]: in function SetPoint' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1116: in function LayoutSections'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1198: in function <Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1166>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:503: in function RefreshContents' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:488: in function ResumeUpdates'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:471: in function <Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:463>
[string "=[C]"]: in function Show' [string "@Interface/AddOns/AdiBags/core/Bags.lua"]:96: in function Open'
[string "@Interface/AddOns/AdiBags/core/Bags.lua"]:126: in function <Interface/AddOns/AdiBags/core/Bags.lua:122>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "TOGGLEBACKPACK"]:1: in function <[string "TOGGLEBACKPACK"]:1>

Locals:

[2]
Message: Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1116: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: AdiBagsSection5:SetPoint.
Time: Fri Nov 18 14:40:33 2022
Count: 7
Stack: Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1116: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: AdiBagsSection5:SetPoint.
[string "@Interface/AddOns/AdiBags/core/Utility.lua"]:88: in function <Interface/AddOns/AdiBags/core/Utility.lua:84>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/AdiBags/widgets/LayeredRegion.lua"]:119: in function <Interface/AddOns/AdiBags/widgets/LayeredRegion.lua:108>

Locals:

commented

@Frurox
Hey, try getting the new version under PR. I actively update new fixes there.
#790
It might or might not help, I don't know because I've never had that error.

Are you getting this as you're loading in? opening the bags or doing something else?
have you tried disabling all the other addons and seeing if this persists?

also are you on Retail, Wrath or Classic?

Thanks,

commented

@MleveK 1st of all thanks for the the work done here while @Cidan is out, I have been following the developments.

I pushed the v5 version you gave, this is retail, I was in the Torgast when I got this errors.

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

Just to clear up a suspicion, if you just use a consumable out of your bag, it closes too? Like a potion or a mana drink

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

Just to clear up a suspicion, if you just use a consumable out of your bag, it closes too? Like a potion or a mana drink

Its anything, so If I swap out gear, sell gear, drop item in vault, any item I take out of bag closes the window

commented

This matches my latest push on PR.
It might not fix your issue if you already took your files from PR.

I cannot replicate your issue, (Both the Anchor error(I just ran a torghast) and Bag closing).
Make sure to try disabling all other addons and any other plugging you might have for Adibags. Also not a bad idea to back up your WTF folder, and clear the Adibags files from there too to reset any settings.

AdiBagsV5.1.zip

commented

This matches my latest push on PR. It might not fix your issue if you already took your files from PR.

I cannot replicate your issue, (Both the Anchor error(I just ran a torghast) and Bag closing). Make sure to try disabling all other addons and any other plugging you might have for Adibags. Also not a bad idea to back up your WTF folder, and clear the Adibags files from there too to reset any settings.

I will give this one a go, I will delete everything in WTF folder too thanks

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

Just to clear up a suspicion, if you just use a consumable out of your bag, it closes too? Like a potion or a mana drink

Its anything, so If I swap out gear, sell gear, drop item in vault, any item I take out of bag closes the window

Yeah, I had this issue in V1. After some fiddling I manage to fix it, but don't know exactly what did it.
One of the things I did was restoring the profile, deleting the adibags files in WFT folder and relogging a few times.

Hope it can help you to fix it too, if you notice anything specific that fixes please update here so the creator can take it into account.

commented

@trdahl that sounds like a Pawn thing. Is it turned on?

Yeah, its activated, but the green arrow is gone ... not sure why, been trying to figure it out all morning

It was temporarily paused as Blizzard removed the Item upgrade check API. It has to work off of PAWN now and Pawn had a bug. That's fixed in the new revision I pushed #790

commented

Here you go:
AdiBags_BoE_BoA_fix.zip

Also I should warn you that a lot of the adibags addons should be rewritten because they create a frame for each item in your bag to get data and it can become very laggy . Some of them do this without the need to do it .... There is a new way in 10.0.2 much more efficient https://wowpedia.fandom.com/wiki/Patch_10.0.2/API_changes .

commented

Here you go:

@Toldorn
Better option here that doesn't create extra frames in 10.0:
https://github.com/AvyAddons/AdiBags_Bound

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

I'm having the same issue as you. I have 5 toons. 2 of 5 having this issue where 3 of 5 don't. I've already deleted the .lua and .bak files from the WTF folder, unfortunately it didn't help.

commented

Thank you all for the hard work

The only thing I am seeing and Im not sure if its part of the addon but everytime I use anything I lose the color around the item for example I will click and then all my epics in my bags lose the color showing that its a purple item

commented

image

image

commented

Thank you all for the hard work

The only thing I am seeing and Im not sure if its part of the addon but everytime I use anything I lose the color around the item for example I will click and then all my epics in my bags lose the color showing that its a purple item

I think Cidan has plans to fix this in the official update after the weekend is up - saw it mentioned #758

I have this problem too, its distracting but not a big issue I think

commented

Thanks, this version is working but every time I deposit something in the bank it closes the window, other than that everything seems to be working OK

This maybe caused by AdiBags_Hearthstones or other plugin.

commented

I no longer see if something is upgradeable etc, is this something thats gonna be fixed, or do we have to live with it?

commented

@trdahl that sounds like a Pawn thing. Is it turned on?

commented

If anyone is interested, i've modified some adibags addons to work with current version and without creating frames.
It includes Archaelogy, Artifact weapons, battlepetitem, boe boa, fishing item, hearthstones, lowlevel, openable.

adibags_addons_fix.zip

commented

@trdahl that sounds like a Pawn thing. Is it turned on?

Yeah, its activated, but the green arrow is gone ... not sure why, been trying to figure it out all morning

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. It's also closing bank frame. If I disable Adibags, base UI or ElvUI doesn't have this issue.
I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue.
I can't figure out the difference between these 2 use cases and the kind of error

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue. I can't figure out the difference between these 2 use cases and the kind of error

I fixed this issue by reseting the profile few times in Adibags' option window.

commented

This is the buggrabber output when I login and try to open bags:

3x Interface/AddOns/AdiBags/core/Hooks.lua:56: attempt to call upvalue 'GetContainerNumSlots' (a nil value) [string "@Interface/AddOns/AdiBags/core/Hooks.lua"]:56: in function (for generator)'
[string "@Interface/AddOns/AdiBags/core/Hooks.lua"]:96: in function <Interface/AddOns/AdiBags/core/Hooks.lua:86>
[string "=(tail call)"]: ?
[string "OPENALLBAGS"]:1: in function <[string "OPENALLBAGS"]:1>

Locals:
maxContainer = 4
id = 0
(*temporary) = nil
(*temporary) = 0
(*temporary) = "attempt to call upvalue 'GetContainerNumSlots' (a nil value)"
hookedBags =

{
}
GetContainerNumSlots = nil
`

I downloaded the latest master from github and replaced the files in the addon folder, adibags seems to be working now. Although I still can't Alt+drag items to other filters in the bag anymore. Also there's no options button on the bag window anymore since the pre-patch so you have to enable right-clicking on the bag to open the options to get to them easily.

commented

If anyone is interested, i've modified some adibags addons to work with current version and without creating frames. It includes Archaelogy, Artifact weapons, battlepetitem, boe boa, fishing item, hearthstones, lowlevel, openable.

adibags_addons_fix.zip

Thank you ! I use some of them, so very helpful.
You have used the addon AdiBags_Fishing_Items, but this one is old and abandonned. Did you know about the addon AdiBags_fishing ? It has been updated for the first pre patch release, but not yet for 10.0.0.2.

commented

Getting this error when I move items into or out of the reagent bag.

1x AdiBags/widgets/ItemButton.lua:500: Usage: GetItemInfo(itemID|"name"|"itemlink")
[string "=[C]"]: ?
[string "@AdiBags/widgets/ItemButton.lua"]:500: in function UpdateBorder' [string "@AdiBags/widgets/ItemButton.lua"]:345: in function Update'
[string "@AdiBags/widgets/ItemButton.lua"]:677: in function <AdiBags/widgets/ItemButton.lua:672>
[string "=(tail call)"]: ?
[string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:114: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:114>
[string "=[C]"]: ?
[string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:24: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:20>
[string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:59: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:54>
[string "=(tail call)"]: ?

commented

Getting this error when I move items into or out of the reagent bag.

1x AdiBags/widgets/ItemButton.lua:500: Usage: GetItemInfo(itemID|"name"|"itemlink") [string "=[C]"]: ? [string "@AdiBags/widgets/ItemButton.lua"]:500: in function UpdateBorder' [string "@AdiBags/widgets/ItemButton.lua"]:345: in function Update' [string "@AdiBags/widgets/ItemButton.lua"]:677: in function <AdiBags/widgets/ItemButton.lua:672> [string "=(tail call)"]: ? [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:114: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:114> [string "=[C]"]: ? [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:24: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:20> [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:59: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:54> [string "=(tail call)"]: ?

Quick fix for this: edit widgets/ItemButton.lua and replace line 500 with:

local quality = hasItem(self.hasItem) and (self.itemLink or self.itemId) and select(3, GetItemInfo(self.itemLink or self.itemId))
commented

Getting this error when I move items into or out of the reagent bag.
1x AdiBags/widgets/ItemButton.lua:500: Usage: GetItemInfo(itemID|"name"|"itemlink") [string "=[C]"]: ? [string "@AdiBags/widgets/ItemButton.lua"]:500: in function UpdateBorder' [string "@AdiBags/widgets/ItemButton.lua"]:345: in function Update' [string "@AdiBags/widgets/ItemButton.lua"]:677: in function <AdiBags/widgets/ItemButton.lua:672> [string "=(tail call)"]: ? [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:114: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:114> [string "=[C]"]: ? [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:24: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:20> [string "@Ace3/CallbackHandler-1.0-7/CallbackHandler-1.0.lua"]:59: in function <...Ons/Ace3/CallbackHandler-1.0/CallbackHandler-1.0.lua:54> [string "=(tail call)"]: ?

Quick fix for this: edit widgets/ItemButton.lua and replace line 500 with:

local quality = hasItem(self.hasItem) and (self.itemLink or self.itemId) and select(3, GetItemInfo(self.itemLink or self.itemId))

This worked perfect, thanks so much.

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue. I can't figure out the difference between these 2 use cases and the kind of error

I fixed this issue by reseting the profile few times in Adibags' option window.

I tried, and even deleted saved variables, no change. So I guess it's not completely related to config

commented

Every time I sell/transfer/use an item on a toon which had Adibags before with this update, the bag window closes. But there is no error. I tried without any addon except Adibags on a new toon, the issue doesn't happen. If I add back addons, one by one, I don'have the issue. I can't figure out the difference between these 2 use cases and the kind of error

I fixed this issue by reseting the profile few times in Adibags' option window.

I tried, and even deleted saved variables, no change. So I guess it's not completely related to config

I too have this issue even when deleting the addon folder and resetting config multiple times. It happens with selling or removing/depositing items in my bank as well.