AdiBags

AdiBags

8M Downloads

Masque support

PINCHO93 opened this issue · 15 comments

commented

Now that you have updated the addon for Legion, could you add support for masque?

commented

Any update?

commented

See #631

commented

What parts of the UI would you like to see use Masque?

commented

The actual items in my bag. So far the "custom" code is working (minor issue with the empty bag slots) So imo it should be fixed and added.

commented

For reference, experimental Masque support was added in 239ac14 and subsequently reverted via 7f88d13.

commented

This will probably be a longer term project after Legion launches. I'll look into it.

commented

IIRC, Masque is intended to work with action buttons, which have not the same layers and components than item buttons. Some of the useful features of a bag addon could not work with Masque skinning.

commented

That makes sense; I don't mind taking at the very least a cursory look at Masque support as I'm sure it has changed over the years.

commented

For reference, someone seems to have figured it out for Bagnon. Perhaps a glance at their code might help point you in the right direction. https://wow.curseforge.com/projects/bagnon-facade

commented

This really isn't that hard to integrate. I created a basic implementation before I stopped playing in legion. If it's something you would like I can clean the code up and submit a pull request.

masque image

commented

@breavyn
How does your implementation differ from 239ac14? Does it account for the additional layers found in item buttons?

commented

Hey! Just downloaded AdiBags and I love it! I was wondering how the Masque support is coming along? I saw that a user (Breavyn) was able to get a basic implementation working. Look forward to any updates. Thank you!

commented

@Talyrius @breavyn @Cidan Any updates on this? Happy to help with the PR.

commented

Hello !
Any news about this feature ? :)

commented

Has anyone been able to get it to work after 9.0? Quality borders are borked.