Profession Window
evilgodly opened this issue · 10 comments
Brought up my JC profession window and got this error.
1x AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua:13619: script ran too long
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:13619: in function `GroupFilter'
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:14045: in function `RecursiveGroupRequirementsFilter'
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:14325: in function `Update'
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:6239: in function <AllTheThings\AllTheThings.lua:6211>
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:6253: in function <AllTheThings\AllTheThings.lua:6245>
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:21113: in function `CacheRecipes'
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:21128: in function <AllTheThings\AllTheThings.lua:21127>
[string "@AllTheThings\AllTheThings-SL-2.8.8-28-ga904a76.lua"]:223: in function <AllTheThings\AllTheThings.lua:217>
Locals:
item = <table> {
sourceParent = <table> {
}
total = 1
visible = false
progress = 1
parent = <table> {
}
hash = "spellID73239"
requireSkill = 755
spellID = 73239
}
(*temporary) = <function> defined @AllTheThings\AllTheThings.lua:800
(*temporary) = <table> {
sourceParent = <table> {
}
total = 1
visible = false
progress = 1
parent = <table> {
}
hash = "spellID73239"
requireSkill = 755
spellID = 73239
}
(*temporary) = "script ran too long"
app = <table> {
CreatePetType = <function> defined @AllTheThings\AllTheThings.lua:9506
SetDataMember = <function> defined @AllTheThings\AllTheThings.lua:678
FunctionRunner = <table> {
}
SpellNameToSpellID = <table> {
}
BaseItemWithFactionID = <table> {
}
UniqueModeItemCollectionHelper = <function> defined @AllTheThings\AllTheThings.lua:14450
IsAccountLinked = <function> defined @AllTheThings\AllTheThings.lua:5483
BaseAzeriteEssence = <table> {
}
PlayCompleteSound = <function> defined @AllTheThings\AllTheThings.lua:1378
CreateHash = <function> defined @AllTheThings\AllTheThings.lua:2800
SpellIDToSkillID = <table> {
}
BaseItem = <table> {
}
FilterItemClass_RequireBinding = <function> defined @AllTheThings\AllTheThings.lua:13703
ToggleMainList = <function> defined @AllTheThings\AllTheThings.lua:6974
AccountWideAchievements = true
PrintGroup = <function> defined @AllTheThings\AllTheThings.lua:93
ItemBindFilter = <function> defined @AllTheThings\AllTheThings.lua:801
FillSymlinkAsync = <function> defined @AllTheThings\AllTheThings.lua:3857
IsComplete = <function> defined @AllTheThings\AllTheThings.lua:2175
BaseItemWithAchievementID = <table> {
}
SearchForField = <function> defined @AllTheThings\AllTheThings.lua:6016
BaseVignette = <table> {
}
TryPopulateQuestRewards = <function> defined @AllTheThings\AllTheThings.lua:8126
PrintTable = <function> defined @AllTheThings\AllTheThings.lua:110
CreateMount = <function> defined @AllTheThings\AllTheThings.lua:12385
TooltipSourceFields = <table> {
}
PlayRareFindSound = <function> defined @AllTheThings\AllTheThings.lua:1388
OpenMiniListForCurrentZone = <function> defined @AllTheThings\AllTheThings.lua:19248
UpdateWindows = <function> defined @AllTheThings\AllTheThings.lua:14769
BaseTitle = <table> {
}
BaseUnit = <table> {
}
CreateDeathClass = <function> defined @AllTheThings\AllTheThings.lua:9819
SortDefaults = <table> {
}
InitDataCoroutine = <function> defined @AllTheThings\AllTheThings.lua:22955
CreateMapWithStyle = <function> defined @AllTheThings\AllTheThings.lua:12231
GetFactionIDByName = <function> defined @AllTheThings\AllTheThings.lua:10067
events = <table> {
}
BasePetType = <table> {
}
RequireFactionFilter = <function> defined @AllTheThings\AllTheThings.lua:13728
MarkUniqueCollectedSourcesBySource = <function> defined @AllTheThings\AllTheThings.lua:13861
CreateFollower = <function> defined @AllTheThings\AllTheThings.lua:10578
FlightPathDB = <table> {
}
print = <function> defined @AllTheThings\AllTheThings.lua:84
CreateFlightPath = <function> defined @AllTheThings\AllTheThings.lua:10488
BuildCostTable = <function> defined @AllTheThings\AllTheThings.lua:4831
FilterItemClass_RequiredSkill = <function> defined @AllTheThings\AllTheThings.lua:13720
RequiredSkillFilter = <function> defined @AllTheThings\AllTheThings.lua:13720
GetCurrentFactionStandings = <function> defined @AllTheThings\AllTheThings.lua:10083
ClassIndex = 2
__callbacks = <table> {
}
CleanSourceIgnoredGroups = <function> defined @AllTh
yes it also happen when i log in to any of my toons but no error then.
System Specs:
OS-Windows 10 Pro
Processor-Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz 3.50 GHz
Installed RAM-16.0 GB
Video Card- NVIDIA RTX 3070 8gb
Resolution- 3840x2160 30Hz
So given you got this script timeout, does that mean your entire game froze for ~25 seconds when you opened your profession list? What sort of hardware specs are you running WoW with?
Samsung SSD M.2 970 EVO Plus 1TB
I can do 60Hz but i forget to change it back, for X reason it changed back to 30Hz.
Have you tried running with only the latest ATT enabled to test the same situation? Your specs are way higher than necessary for WoW so you should have basically zero lag or stutter from ATT at all. We might be looking at some obscure bug which locks up the game perhaps otherwise.
Can you try the same situation but with only ATT enabled using the same Settings? And see if it still locks up? Also can you post your settings screens just so we can try to replicate this accurately? Maybe it was magically fixed in 2.8.9?
I get this Error in Profession list. Version 2.8.9
Message: Interface\AddOns\AllTheThings\AllTheThings.lua:15532: attempt to index local 'profile' (a nil value)
Time: Mon Jul 25 21:42:47 2022
Count: 4
Stack: Interface\AddOns\AllTheThings\AllTheThings.lua:15532: attempt to index local 'profile' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:15532: in function `StorePosition'
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:15484: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:15479>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:15772: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:15770>
Locals:
Weird... wonder how you managed to have this happen... It's like your current ATT Profile data was deleted, without un-assigning the specific profile from the current character. I believe this was a potential issue I fixed a while ago, so possibly you had deleted a profile used by multiple characters quite some time ago, but never changed the Profile for the current character, so it was still trying to reference the data from a Profile which no longer exists?
Seems this is likely a niche situation... I'll try to throw in a logic change to ensure this doesn't error for users in this situation, but it should get fixed up if you change the ATT Profile for that character (and maybe others) to not be using a Profile which doesn't actually exist anymore.
Oh whoops. I see it was a completely different issue posted as a comment about this issue. Re-opened....
Have you tried running with only the latest ATT enabled to test the same situation? Your specs are way higher than necessary for WoW so you should have basically zero lag or stutter from ATT at all. We might be looking at some obscure bug which locks up the game perhaps otherwise.
Can you try the same situation but with only ATT enabled using the same Settings? And see if it still locks up? Also can you post your settings screens just so we can try to replicate this accurately? Maybe it was magically fixed in 2.8.9?
So far no issues. When i log in it will still freeze up for a little bit, maybe 3 seconds, and then clears up. So i would have to say issue resolved for me.
Have you tried running with only the latest ATT enabled to test the same situation? Your specs are way higher than necessary for WoW so you should have basically zero lag or stutter from ATT at all. We might be looking at some obscure bug which locks up the game perhaps otherwise.
Can you try the same situation but with only ATT enabled using the same Settings? And see if it still locks up? Also can you post your settings screens just so we can try to replicate this accurately? Maybe it was magically fixed in 2.8.9?So far no issues. When i log in it will still freeze up for a little bit, maybe 3 seconds, and then clears up. So i would have to say issue resolved for me.
Well that might mean it's not specifically ATT's fault your game literally lags out, but something else is interfering clearly. If you manage to re-enable other add-ons and notice which one interacts poorly to cause the lag, that would be nice to know for future problem solving.
Also the initial lag at the beginning is expected, though I thought it usually takes place during the load screen. Unless you don't have "Ad-Hoc" enabled, it will refresh the Main list when you log on, which will also lag a couple seconds.