[suggestion] Add the Command key (Mac) as option to the tooltip modifier keys
tflo opened this issue · 5 comments
On the Mac, it would be great if we could set the Command key as modifier for the tooltip, as it is our main modifier key and in best thumb position.
The function in 9.2.7 is
IsMetaKeyDown()This returns true for the left and right Command key, and seems to be the same as IsLeftMetaKeyDown(), which also returns true for both (left and right) keys (whereas IsRightMetaKeyDown() exists but it returns always false, also for the right one).
If you want to test for the Mac platform, the function is IsMacClient().
I have no idea if this works in the Classic clients too. (For the mainline, they have added the Command key as modifier only with 9.0.)
The short name of the key (for your GUI) is “Cmd”.1
Many thanks for considering,
– Tom
Footnotes
-
“Meta key” is Blizz speak but on the Mac this term does not exist as name for the Command/Cmd key. In the Keybindings section of the client they also use “CMD”, in macros we can use both terms (
[mod:cmd]or[mod:meta]). ↩
Looked into this a bit, and it seems as though this would need to be a new modifier which is only added for Mac clients? I'm assuming it's possible to still use the other modifiers on a Mac as well such that I couldn't just replace one of the others on a Mac client...
Don't have much time, but I'll try to figure this out at some point. Note that I don't have a Mac myself so I'll have to spoof the functionality for testing and hopefully if/when it gets added fully, you (@tflo) will be able to verify on a real Mac :)
Indeed, I have some real Macs :) Just let me know when you have a test version ready.
I'm assuming it's possible to still use the other modifiers on a Mac
This is correct. We actually have 4 working modifiers in the game (Cmd, Opt (aka 'alt'), Ctrl, Shift), so it would be preferable to add it, instead of replacing another one.
(In addition, if you replace an existing one, this would just confuse people if they had set their modifier to the one that got removed ;)
In the ATT GUI (Interface settings), if you move the "Modifier" label up to "Tooltip Integrations", then you have the perfect space for the 4 modifier and 1 'none' checkboxes. Like this:
☑️ Tooltip Integrations – Modifier:
☑️ None ☑️ Cmd ☑️ Shift ☑️ Ctrl ☑️Alt
Or, remove the 'none' checkbox and make the other checkboxes behave like normal checkboxes (1st click ticks, 2nd click unticks), then you'll also have the space.
And, with the 2nd solution, you have the choice if you allow modifier combos (eg Shift-Alt), or just take the first one in case of multiple ticks.
But be careful, if you decide to allow combos, the order how you build the combo (in your code) might be crucial! (Independently of the Cmd key, also for the other ones.)
I cloned it and it looks great…
… and it works :)
Thank you very much, especially for having forked some of your time during this time of DF changes mess!
– Tom