ALL THE THINGS

ALL THE THINGS

31M Downloads

Any way to tone down the resource impact? Load on Demand stuff or disable auto scanning?

Raven7576 opened this issue ยท 9 comments

commented

Hey guys,

I just wanted to make a suggestion, Ive been using the addon for a couple weeks now and I have a couple pet peeves. I dont mean to critize it too much, its an impressive addon and one that I'd love to see myself using for the rest of the time I play the game.

I feel like the resource usage is a little high, I have a decent computer but using it causes major frame rate drops to occur doing some of the most basic things. I bought out a few mini-pets from the Auction House and each one causes a major drop to occur when I was adding them to my collection. It interrupted the Blizz animation of "Mini pet A added to collection" which for me personally just kinda breaks the immersion. So my suggestion, Is there anyway to make it so that the user controls when ATT updates, and not for it to auto update each time something new is added? Am I missing something that I can prevent it from actively scanning every time the collection changes?

Additionally, I noticed some of the show/hide pieces do not corespondent what is actually listed on ATT. So something like "PVP" cant be hidden. I know the purpose of the mini-list is to make a watch list of sorts but I feel like my personal tastes would lead to a lot being disabled allowing for a lighter footprint from the addon.

commented

I feel like the resource usage is a little high,

This is because the database is stored within the addon. If we didn't do this you would experience extreme amounts of slow down due to how slow the API is and the calculations needed

bought out a few mini-pets from the Auction House and each one causes a major drop to occur when I was adding them to my collection. It interrupted the Blizz animation of "Mini pet A added to collection" which for me personally just kinda breaks the immersion.

What other addons are you running as I have not experienced this at all. Can you reproduce it with no addons, but ATT installed?

So my suggestion, Is there anyway to make it so that the user controls when ATT updates, and not for it to auto update each time something new is added? Am I missing something that I can prevent it from actively scanning every time the collection changes?

ATT updates when Blizzard sends out a notification flag. When means after any popups, etc.

Additionally, I noticed some of the show/hide pieces do not corespondent what is actually listed on ATT. So something like "PVP" cant be hidden. I know the purpose of the mini-list is to make a watch list of sorts but I feel like my personal tastes would lead to a lot being disabled allowing for a lighter footprint from the addon.

Disabling things doesn't change anything as the database is set and stored. So disabling various parts wouldn't delete it from the database. Again, this is done in order to reduce the amount of issues that would occur using the API only.

There currently isn't, nor will be, a blacklist option. PvP gear makes up roughly 30-40% of the available transmog out there and with it's primary focus on transmog we don't see it as a viable option to blacklist things are people can blacklist everything, achieve 100% but still only have 10% of the items. That's the primary focus, and part of why it has it's name of "All The Things"

commented

ATT updates when Blizzard sends out a notification flag. When means after any popups, etc.

Is there a method to debug the rate of this notification flag (perhaps broken down by type), so we can see if an excessive amount of such notifications could be the cause?

commented

First off, sorry if I was stepping on toes with my first comment. I do enjoy the app, its just finding how I can make the most of it for what I want with it. I didnt know that there are two types of a mini list. One that you can send items to, like a watch list, and another that if you ctrl click it will show you the zone (Handy!) The main list is incredibly intimidating at first and seems almost impossible to navigate. I do have a side suggestion too with that, changing the default click options for the map icon. I know its just a modifier key to hit but it would be cool to just click the icon for a zone list.

As far as the mini pet thing, I've disabled all addons except ATT, bought a couple mini pets from the AH and tried to add them to my collection. Each time I add one, the game freezes for a second or two RIGHT before the "added to collection" notification occurs. For informational purposes, I have 16 gigs of ram and an i5-6500 processor. I know the game runs well otherwise and I'm stumped as what it can be. Hope that helps, hopefully you can find the bottleneck if there is one.

commented

I am having the same issue, the game freezes for a second everytime something is added to the collection (mounts, pets) but not transmog appearance.
I have disabled all addon aswell except ATT.

commented

I've noticed the same issue with pets and mounts. Every time I learn one, the game freezes for a second right before the audio notification is played. The problem started to happen since the BfA prepatch.

commented

I am running 1.6.7.

commented

I know the addon is called "All The Things" for a reason. I think you guys have a steller addon so my only suggestion is that Im just more interested in a per expansion basis of these things. I'd like to know how much of an expansion I've done and how much I have left. Breaking down the addon into a Core and Misc with Exp 1, Exp 2, etc plugins would be pretty useful. I feel like the addon will one day get really bloated as its just added more and more layers.

Also in concern with the mini pets. I understand that there are algorithms and what not, but why isnt is just a predefined list? There are a fixed number of mini pets right now, it should just be a check mark off an offline list, not a math problem.

I want to highlight again, that Im not trying be overly critical. I hate to be that angry guy on the internet with zero scope of the situation. I do like the addon, I just want to have a reason to keep it. Slow downs and memory usage thats much larger than anything else I have in addon's is kinda a buzzkill.

commented

Is there a method to debug the rate of this notification flag (perhaps broken down by type), so we can see if an excessive amount of such notifications could be the cause?

If you have the notifications turned on then that is about the only way to debug as we'll send a flag when Blizzard sends a flag (even if Blizzard sends a hidden flag; Example: All classes learning Shadowstrike/Thunderstrike)

image

I know its just a modifier key to hit but it would be cool to just click the icon for a zone list.

It might be easier to set a keybinding up in the options menu to whatever key you want.

image

What versions are you running?

Also, when learning new items several algorithms are ran at once. First is Blizzard sending back a response (this causing some delay as their API is pretty slow to start with). Followed up with is it a new thing or repeat. Most of the time any slow down you would experience is because the API is just that slow in general. This is one of the reasons we opted for making our own "dynamic" lists. We originally had it to where the Pet / Mount Journal pulled from the API to list all mounts automatically, but it increased a dramatic slowdown of a good 5-8 seconds on even decent hardware.

commented

@alexnaumovich

I am running 1.6.7.

Thanks. I just wanted to double check to make sure it wasn't around the 1.64 area where there were some bugs with Blizzard API overall.

@Razertongue

I know the addon is called "All The Things" for a reason. I think you guys have a steller addon so my only suggestion is that Im just more interested in a per expansion basis of these things. I'd like to know how much of an expansion I've done and how much I have left. Breaking down the addon into a Core and Misc with Exp 1, Exp 2, etc plugins would be pretty useful. I feel like the addon will one day get really bloated as its just added more and more layers.

I kind of already is like that. We have Dungeons and Raids broken down by their expansion along with World Drops.

Doing outdoor content like this isn't exactly feasible for a few reasons. First being we have Classic/BC(ZA) that is being reused in Cataclysm content. Then we have Legion content that uses a bunch of zones as well. Here it's easier to break it down by continent which for the most part works as expansions with the few slight exceptions.

Each category however is broken down in a way to where you can classify it into expansions. The exceptions to this are Item Sets / Pet Journal / Toy Box / Mounts where these are copies in a way what the Blizz UI gives.

Doing plugins with this type of addon wouldn't really be feasible and break a lot of things in terms of it's usefulness. Right now I can hover one item and tell all of it's sources. You wouldn't be able to do that with plugins / modules. For instance I can see that in Mists of Pandaria there is a pet from a satchel, but if I was to hover it I can see in Wrath of the Lich King it's purchasable for a currency. I can see one pet given in this expansion as a reward and another expansion for gold.

Also in concern with the mini pets. I understand that there are algorithms and what not, but why isnt is just a predefined list? There are a fixed number of mini pets right now, it should just be a check mark off an offline list, not a math problem.

You have the algorithm of the following:

  1. What pet are you learning? Looked up via species
  2. Is it a new pet?
  3. Is it a duplicate pet? (ie do you have 1/3, 2/3)
  4. Did you remove a pet?

It's not a lot per say, but when communicating with the API and seeing what it is can yield in slow responses.

I want to highlight again, that Im not trying be overly critical. I hate to be that angry guy on the internet with zero scope of the situation. I do like the addon, I just want to have a reason to keep it. Slow downs and memory usage thats much larger than anything else I have in addon's is kinda a buzzkill.

That's fine, because most don't understand the why's behind it and just see bad things and that's it. As for memory usage it's because we stored the db client side. Which is a huge gain for users. With that it makes item lookups and such a lot easier. If we didn't store that information client side it would be a lot slower than it is now because each item would have to be looked up. This would be even more noticeable if you were in Unique mode. Also without it there wouldn't be a "I only care about my main" mode.

The pet things might be related to something else that we've noticed, but we haven't had a chance to fully sit down and start debugging it. The few of us that would be able to help pinpoint it just haven't had time because of real life where as personally I've been busy prepping it for Battle For Azeroth on Monday/Tuesday.