ALL THE THINGS

ALL THE THINGS

31M Downloads

BFA Arathi Highlands vs. CATA Arathi Highlands

kcoderhere opened this issue ยท 11 comments

commented

I went to the BFA version of Arathi Highlands (on Alliance during a "patrol" day) but ATT was reporting I was in the Cata version, showing Cata quests and not showing the BFA rares I needed.

Using DF-3.8.10

commented

This now works correctly for both warfronts

commented

If I understand it correctly it is the same issue in Darkshore.

Mini list (on the left) shows only quests from the normal Darkshore. Main list (on the right) shows there is some stuff I can collect in the BFA version.

I am pretty sure the War Effort stuff was shown in the mini list some time ago. Would be great to see both version in the mini list again.

image

commented

There was logic added such that these zones only show the content for the specific phase you are currently in, but there are currently some issues with that and it needs to be revised further and perhaps use a different detection mechanism to properly check the current phase.
If this tech expands to more zones which have global phasing, I could see us adding a setting to toggle this functionality from taking place.

commented

I would love to have a setting to disable this feature.

I use the mini list all the time as reminder what else I can do if I visit a zone.

And if it only shows the active zone I miss the "take 10 seconds to switch phases and get XY"

commented

I found some more information about this. Both phases share the same map ID (14), however you can get the correct info by using:
C_Map.GetMapArtID(14)

Old Arathi will return 15
New Arathi will return 1137

This was only tested on Alliance and during an Alliance Controlled day. I'm just guessing 15 = old Arathi Highlands, anything else = BFA Arathi Highlands

commented

I'm going to take a look at this and see if we can switch mapID based on artID

commented

Darkshore seems to have the same issue. They both return Map ID 62.
C_Map.GetMapArtID(62)
Old Darkshore will return 67
New Darkshore will return 1176 (tested on Alliance during a Horde Controlled day)

commented

This should be testable on Git now. Please let me know if it fixes the issue! (We will likely need artIDs for the opposite factions as well)

commented

image
Confirmed working in Arathi!
Talked to Zidormi and went to old Arathi and got the correct mini list!
image

I noticed that C_Map.GetMapArtID(14) works outside of the zone, so I went to test it on a horde character.
C_Map.GetMapArtID(14) returns 1137
C_Map.GetMapArtID(62) reutrns 1176

So there might be some additional testing needed just in case there are different ArtIDs for different "phases" (Alliance Patrol Day vs. Horde Patrol Day)

One minor side effect is that the "Open mini list for Arathi Highlands" button on the minimap will show the wrong one. Although, I think it would be a nice enhancement if clicking it multiple times would toggle between the two mini lists.

commented

You're saying the world map button does that? Okay, I'll look into it

commented

image
Yes, this button