My game freezes whenever I try to close the trade skill window with both of the addons enabled (in my case, enchanting). The freeze also happens if the window closes due to another event, such as using a mage teleport skill.

I can only assume this has been fixed or is in a workable state by now. If not, please refer to the (retail) errors channel on our Discord to place a more detailed report. :)

I can confirm that this problem still exists in version BFA 2.0.6 together with TSM 4.9.38. Switching to the WowUI before closing the windows omits the crash.

It would be great if there was a fix for this, as I'm currently crashing my game quite often.

I have dug a bit into the code and the problem seems to lie with setting the ATT frame invisible when closing the TSM windows. There is an event handler for TRADE_SKILL_CLOSE but at the same time a few lines below the show, hide and setVisible methods of the TSM frame get replaces with versions that also set the ATT visibility. This combination seems to trigger something twice. If I alter the code at line 12481 as below, the error disappears (but the ATT frame stays visible).

elseif e == "TRADE_SKILL_CLOSE" then
	if not((TSM_API and TSMAPI_FOUR) or TSMCraftingTradeSkillFrame) then
		self:SetVisible(false);
	end
end

As this prevents the problem, I will keep this modification, but there is still the issue with the ATT frame not being closed.

I cannot trigger the crash now, is this still relevant?