ALL THE THINGS

ALL THE THINGS

31M Downloads

a big error LUA is poping in naxxramas

milotic opened this issue · 4 comments

commented
Date: 2020-08-05 20:03:15
ID: 29
Error occured in: Global
Count: 1
Message: ..\AddOns\AllTheThings\AllTheThings.lua line 9399:
   attempt to perform arithmetic on field '?' (a nil value)
Debug:
   [string "@AllTheThings\AllTheThings.lua"]:9399:
      AllTheThings\AllTheThings.lua:9002
Locals:
self = <unnamed> {
 0 = <userdata>
 ref = <table> {
 }
 index = 18
 Label = <unnamed> {
 }
 Summary = <unnamed> {
 }
 Background = <unnamed> {
 }
 Indicator = <unnamed> {
 }
 Texture = <unnamed> {
 }
}
reference = <table> {
 parent = <table> {
 }
 visible = true
}
title = nil
lvl = 80
numSpecializations = 3
encounterID = 1607
difficultyID = 3
encounterCache = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
}
itemList = <table> {
 1 = <table> {
 }
 2 = <table> {
 }
 3 = <table> {
 }
 4 = <table> {
 }
 5 = <table> {
 }
 6 = <table> {
 }
 7 = <table> {
 }
 8 = <table> {
 }
 9 = <table> {
 }
 10 = <table> {
 }
}
specHits = <table> {
 63 = 1
 265 = 1
 266 = 1
 267 = 1
 62 = 1
 64 = 1
 256 = 1
 257 = 1
 258 = 1
}
totalItems = 10
currentSpecID = 252
specs = <table> {
 1 = 265
 2 = 256
 3 = 257
 4 = 258
 5 = 267
 6 = 266
 7 = 62
 8 = 63
 9 = 64
}
mySpecs = <table> {
 252 = true
 251 = true
 250 = true
}
least = 99999999
bestSpecID = nil
matchingSpecs = <table> {
}
most = 0
bestLegacySpecID = 250
(*temporary) = nil
(*temporary) = 1
(*temporary) = 250
(*temporary) = "Sangre"
(*temporary) = "Un guardián oscuro que manipula y corrompe la energía vital para sostenerse frente al ataque del enemigo.

Arma preferida: Hacha, maza, espada de dos manos"
(*temporary) = 135770
(*temporary) = "TANK"
(*temporary) = 1
(*temporary) = "TANK"
(*temporary) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on field '?' (a nil value)"
GameTooltipIcon = <unnamed> {
 0 = <userdata>
 icon = <unnamed> {
 }
}
GameTooltipModel = ATTGameTooltipModel {
 0 = <userdata>
 SetRotation = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:524
 HideAllModels = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:502
 TrySetDisplayInfos = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:530
 TrySetModel = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:571
 Models = <table> {
 }
 Model = <unnamed> {
 }
 lastModel = <table> {
 }
 SetCreatureID = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:508
 SetScale = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:527
}
L = <table> {
 NOT_TRADEABLE = "Not Tradeable"
 TOGGLE_RANDOM = "Toggle ATT Random"
 I_ONLY_CARE_ABOUT_MY_MAIN = "I only care about my main."
 TRADEABLE = "Tradeable"
 TOGGLE_MINILIST = "Toggle ATT Mini List"
 TOGGLE_COMPLETIONIST_MODE = "Toggle Completionist Mode"
 LOCKOUT = "Lockout"
 OTHER_ROW_INSTRUCTIONS_AH = "Left Click to Expand/Collapse
Right Click to Pop Out to Mini List
Shift + Click to Search the Auction House"
 FACTION_ID = "Faction ID"
 SAVED_TO_DJ_INSTANCES = <table> {
 }
 QUEST_ID = "Quest ID"
 TOGGLE_BOEITEMS = "Toggle BoE/BoA Items"
 TOP_ROW_INSTRUCTIONS_AH = "Left Click and Drag to Move
Right Click to Open the Settings Menu
Shift + Click to Search the Auction House"
 ABBREVIATIONS = <table> {
 }
 SPLIT = "Per Difficulty"
 DROP_RATE = "Drop Rate"
 SECRETS_HEADER = "Secrets"
 LOGO_SMALL = "Interface\Addons\AllTheThings\assets\logo_tiny"
 MOUNT_ID = "Mount ID"
 ITEM_ID_REMOVED_SHARED = "%s (%d) [+%d] were removed from your collection."
 TOGGLE_COLLECTEDTHINGS = "Toggle Collected Things"
 UNKNOWN_ON_CHARACTER = " Unknown on current character"
 ITEM_ID_REMOVED = "%s (%d) was removed from your collection."
 PREFERENCES = "Preferences"
 iLvl = "iLvl"
 ARTIFACT_ID = "Artifact ID"
 CUSTOM_DIFFICULTIES = <table> {
 }
 AZERITE_ESSENCE_ID = "Azerite Essence ID"
 NPC_ID_NAMES = <table> {
 }
 ITEM_ID_ADDED_RANK = "%s (%d) [Rank %d] was added to your collection."
 RECENTLY_MADE_OBTAINABLE = "If this recently dropped for you (anywhere but Salvage
Crates), please post in Discord where you got it to drop!"
 COMPLETE_ICON = ""
 MUSIC_ROLL_ID = "Music Roll ID"
 TOGGLE_DEBUG_MODE = "Toggle Debug Mode"
 TITLE = "ALL
commented

We are aware of this issue but I'm not sure when it will be fixed as only a few people can solve it (and there's a lot going on in Classic now).

commented

I haven't been able to replicate this. Any further information concerning the current character/class/spec would be handy as this seems to concern code which is attempting to determine loot drop chances based on the encounter loot available alongside the item in question. Theoretically it should only happen when opening a tooltip of an item which drops from an encounter which is found in the dungeon journal.

Also as #520 was merged recently, this may no longer be a bug since a lot of the loot spec code was modified.

If we can determine accurate, reproducible steps to get this bug using the 2.0.6 version, and cannot repeat the bug in the latest Git version, it may be fixed.

commented

Yes, this is indeed fixed now.
The problem was in these lines: this and this, should have been bestLegacySpecID in both cases I think.
But doesn't matter now, thanks for that PR again.

commented

This will be fixed in next release, for now you can download current in-development version with fix here.