ALL THE THINGS

ALL THE THINGS

31M Downloads

Dimensional Ripper schematic does not honor Engineering specialization

kallesommernielsen opened this issue ยท 5 comments

commented

After the Shadowlands update patch, the "[Dimensional Ripper - Everlook]" is listed as a missing schematic, despite my Engineering specialization being Gnomish. All other Goblin engineering schematic seems to honor this except for the dimensional ripper.

SpellID: 23486

commented

Certain recipes (including the one mentioned on this issue) are still listed under both Engineering and Goblin Engineering, but I've made sure the Parser properly syncs certain data for recipes such that the specialization requirement is accurate in all Sources.

commented

@kallesommernielsen Is this still an issue? There were some problems with recipes initially for Shadowlands because Blizzard decided to remove a lot of information from their API results, thus leading to many recipes basically having no restrictions.
This was fixed after another release or two, and currently the data for this recipes appears to be accurate. If it's still occurring then there might be another problem somewhere.

commented

Actually reviewing further, this is probably still an issue. But I don't see why this specific Goblin Engineering recipe would not work while other ones do work. It seems all Goblin/Gnomish recipes are duplicated, once in the general Engineering section, and once in the Specialization section. Thus there is a version of each recipe which specifies only Engineering required and one version which specifies the Specialization as required. Will have to review this further at some point...

commented

There are no two versions of Goblin or Gnome Engineering recipes. I was the one who originally made the commit that allows filter recipes per Engineering specialization and I did that by creating new lua files for the two specializations and manually move there the recipes that require specialization. I think the problem is that the profession lua files have been regenerated with some automation based on data obtained for Blizzard API, but Blizzard profession API data does not contain information like specialization requirement so the automation process has reverted those manual changes made on the normal Engineering lua files.

Here is the original pull
#322

commented

Ah, yea I also had to modify part of the custom utility which generates the addon's database due to the API changes no longer being as useful as they previously were (good job Blizzard).

Hopefully with a bit more research, I can have the specialization patterns which are duplicated under the default professions cleaned out of the addon database, OR modify the in-game addon filtering logic to properly handle the extra specialization requirements. We will see.