Calling protected function 'CompactRaidFrame1:ClearAllPoints()'
addonaddict opened this issue ยท 14 comments
Happens very often lately, last few times I remember it happen was during a mythic+0 dungeon
Here are the addons I have on at the time
1x [ADDON_ACTION_BLOCKED] AddOn 'AllTheThings' tried to call the protected function 'CompactRaidFrame4:Show()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function Show' [string "@FrameXML\CompactUnitFrame.lua"]:376: in function
CompactUnitFrame_UpdateVisible'
[string "@FrameXML\CompactUnitFrame.lua"]:307: in function `CompactUnitFrame_UpdateAll'
[string "@FrameXML\CompactUnitFrame.lua"]:126: in function <FrameXML\CompactUnitFrame.lua:57>
Locals:
Skipped (In Encounter)
This is really strange... I don't even know what is causing it to call that function on that frame. And almost all the logic that ATT runs is blocked from running during combat, and the stack trace shows default Blizzard functions then an ATT function? Very strange...
Sorry i wish i could help more
I will watch out for when it happens again so I can give you more detail into what might be causing it
Hello there, im getting the same error after the last update, but with a slightly different errormsg. Raidframes just goes away as soon as combat starts, if ATT isnt enabled raidframes works as they are supposed to. The following is the errormsg i get in bugsack
1x [ADDON_ACTION_BLOCKED] AddOn 'AllTheThings' tried to call the protected function 'CompactRaidFrame1:ClearAllPoints()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function ClearAllPoints' [string "@FrameXML\FlowContainer.lua"]:157: in function
FlowContainer_DoLayout'
[string "@FrameXML\FlowContainer.lua"]:17: in function FlowContainer_ResumeUpdates' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:185: in function
CompactRaidFrameContainer_LayoutFrames'
[string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:130: in function CompactRaidFrameContainer_TryUpdate' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:57: in function
CompactRaidFrameContainer_OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>
Anyone using the latest Git version, please check if you still can replicate this issue. It seems to only happen when the following is true/occurs:
- Have default Blizzard Raid Frames shown (i.e. no Addon that replaces/hides them)
- Be in Combat
- Invite/Remove a Player from the Group/Raid
Apparently the root cause for this was when I added a UIDropDown to the Settings, and this taints the underlying frames used by anything which creates a default Dropdown menu in the game, including the CompactRaidFrames, which are inherently secure due to being Blizzard frames. Thus when the CompactRaidFrames need to update and create their own Dropdown, it attempts to utilize the shared, tainted, default Dropdown menu from the secure frames, and the call is blocked. Whew.
(b3314ee) moves the Dropdown creation into a handy 'securecall()' function which apparently allows for calling functions securely even when they are called from Addons, which are inherently insecure (tainted). Doing this caused the ADDON_ACTION_BLOCKED to no longer fire for me in the above situation.
If anyone else can confirm that this is now fixed for them, we can close this.
Will try it and let you know if I get this issue, thank you so much, you're a genius
tested for few days now and have not seen the issue, although i havent been in party/raid much
After the last update i do not get the error any more. So something worked in the code again :) And info from your post that fits the error i had was: Invite/Remove a Player from the Group/Raid (combat/no combat didnt change anything, and i tried both with and without the original raidframes and none of them worked then but does now), as soon as i or another player got joined the error triggered. But thanks for the fix, works like a charm now.
Got another error when joining a raid group for weekly world quest "oranomonos the everbranching" while in combat
1x [ADDON_ACTION_BLOCKED] AddOn 'AllTheThings' tried to call the protected function 'CompactRaidFrame2:ClearAllPoints()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function ClearAllPoints' [string "@FrameXML\FlowContainer.lua"]:157: in function
FlowContainer_DoLayout'
[string "@FrameXML\FlowContainer.lua"]:17: in function FlowContainer_ResumeUpdates' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:185: in function
CompactRaidFrameContainer_LayoutFrames'
[string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:130: in function CompactRaidFrameContainer_TryUpdate' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:57: in function
CompactRaidFrameContainer_OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>
Also caused this when clicking on anyones raid frames while raid is in combat on world boss
Very annoying :(
@addonaddict I pushed another adjustment to try fixing this issue in (3c9c7e4) if you could let me know if that change has any impact to the error you are getting.
Just updated and got the error again in theater of pain in maldraxxus while doing stuff in combat (joining group etc)
I tried to queue while in combat and got the infamous ultimate annoyance addon blocking blizzard UI something yatta yatta BS.
Perhaps 2 are connected? Had to reload and it worked fine, but then got the bug:
1x [ADDON_ACTION_BLOCKED] AddOn 'AllTheThings' tried to call the protected function 'CompactRaidFrame1:ClearAllPoints()'.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function ClearAllPoints' [string "@FrameXML\FlowContainer.lua"]:157: in function
FlowContainer_DoLayout'
[string "@FrameXML\FlowContainer.lua"]:17: in function FlowContainer_ResumeUpdates' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:185: in function
CompactRaidFrameContainer_LayoutFrames'
[string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:130: in function CompactRaidFrameContainer_TryUpdate' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:57: in function
CompactRaidFrameContainer_OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>
Sorry, thanks for trying!
I noticed this kind of error is famous to many other addons... everything about blizzard default raid frames is just garbage once you start introducing more than 5 different addons
@addonaddict I got rid of the dropdown entirely since there seemed to be no easy way to deal with Blizzard's code. This should fix the taint issues for good.