[bug/needs more testing] Stack Overflow
JourneyOver opened this issue ยท 14 comments
Not sure what exactly is causing this issue, but it seems to happen when mousing over things like items in bag and such. Will continue to do some testing to see if I can pinpoint it exactly as it doesn't happen all the time, and it never seems to reoccur on the same things either sometimes.
Error message:
AddOns\AllTheThings\AllTheThings.lua:970: stack overflow
Count: 3
Call Stack:
[string "@AddOns\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua"]:758: in function <...Ons\TradeSkillMaster\LibTSM\Service\ErrorHandler.lua:717>
[string "=[C]"]: ?
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
[string "@AddOns\AllTheThings\AllTheThings.lua"]:970: in function <AddOns\AllTheThings\AllTheThings.lua:965>
...
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@AddOns\TradeSkillMaster\LibTSM\Service\ItemTooltipClasses\Wrapper.lua"]:98: in function <...Master\LibTSM\Service\ItemTooltipClasses\Wrapper.lua:96>
[string "=[C]"]: ?
[string "@AddOns\Vendor\sys\hook.lua"]:95: in function <AddOns\Vendor\sys\hook.lua:91>
[string "=[C]"]: in function `SetBagItem'
[string "@FrameXML\ContainerFrame.lua"]:1324: in function `ContainerFrameItemButton_OnUpdate'
[string "@FrameXML\ContainerFrame.lua"]:1371: in function `ContainerFrameItemButton_OnEnter'
[string "*:OnEnter"]:1: in function <[string "*:OnEnter"]:1>
[string "=[C]"]: ?
I'm seeing the same thing. It seems to be directly related to a conflict with TSM. I disabled the "Embed TSM tooltip" option and reloaded, and I haven't seen the error again so far.
Sounds good, I did change additional things in the search logic to try to avoid some weirdness that was happening in very specific situations, so maybe that helped prevent some loop somewhere.
Toggling Debug Mode or Account Mode will wipe the cached tooltip search results (which is why it only would happen on the first hover of an item) and allow pin-pointing which specific item in your bags is causing this issue to help us fix the data concerning the item.
Also make sure you are on the latest version (2.2.0) as there were two items associated with Revendreth Rares which had themselves listed within a group that they were tied to, meaning it caused an infinite loop of references. That should have been fixed though for the latest release.
Putting code to check for infinite loops everywhere could definitely catch these issues without causing errors in the addon, but would also create unnecessary logic processing for all other situations, so ideally we want to just fix the data which is causing these infinite loops and leave the logic simple.
If there is truly some conflict with TSM instead, then hopefully we can find a way to resolve it if possible.
@ImUnicke so I've tried both debug mode and account mode, and so far haven't been able to reproduce the error again (and I moused over every single item in my bags/bank), which seems to be typical whenever I report a bug/issue (magically goes away after the report) xD though I am working from ATT commit 0652621 and not from curseforge. So maybe some commit between the last time (don't remember the exact commit I was on when it last popped) the error popped for me and now seems to have fixed it?
Not going to say close this issue right now and instead just give it a few days to see if it decides to randomly happen again and I'll make sure to write down whatever it was that had caused it.
Ok - I've been able to track down two items that are causing it (still happening in the latest release):
https://www.wowhead.com/item=180167/death-god-mask
and
Hmm I have both those items in my bags and I wasn't able to repro on my side when I was messing with things yesterday, even after toggling the debug or account mode stuff to wipe the cached tooltip search results.
@Caerdon Which version of ATT are you using? The latest published version 2.2.0 or using the latest Git changes?
I also get it on https://www.wowhead.com/item=182329/dominations-calling
It seems to require doing something else first. Right after a /reload it doesn't cause the issue. Run a dungeon or something then it randomly happens.
I don't have TSM installed (but I do have a LOT of addons).
Message: Interface\AddOns\AllTheThings\AllTheThings.lua:970: stack overflow
Time: Sun Jan 3 23:40:38 2021
Count: 1
Stack: Interface\AddOns\AllTheThings\AllTheThings.lua:970: stack overflow
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
[string "@Interface\AddOns\AllTheThings\AllTheThings.lua"]:970: in function <Interface\AddOns\AllTheThings\AllTheThings.lua:965>
...
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `SetBagItem'
[string "@Interface\FrameXML\ContainerFrame.lua"]:1324: in function `ContainerFrameItemButton_OnUpdate'
[string "@Interface\FrameXML\ContainerFrame.lua"]:1371: in function `ContainerFrameItemButton_OnEnter'
[string "@Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua"]:369: in function `ShowTooltip'
[string "@Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua"]:340: in function `UpdateTooltip'
[string "@Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua"]:180: in function <...face\AddOns\Bagnon\common\Wildpants\classes\item.lua:179>
Locals: group = <table> {
hash = "npcID170303"
total = 1
parent = <table> {
}
visible = false
progress = 1
}
l = 16365
(*temporary) = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:965
(*temporary) = <table> {
total = 1
info = <table> {
}
progress = 1
collectionText = "1 / 1 (100.00%)"
g = <table> {
}
working = false
}
(*temporary) = 16366
(*temporary) = "stack overflow"
BuildSourceText = <function> defined @Interface\AddOns\AllTheThings\AllTheThings.lua:965
Domination's Calling was also setup in a way that would cause the infinite loop it seems with the logic in the latest release, so I've fixed that now for the next release as well.
@ImUnicke So far I still haven't been able to replicate this since my last post, so imo I think this could probably be closed, but I'll leave it up to you.
Is anyone able to still replicate this anywhere using version 2.2.1 or later? Otherwise I think we can close this as resolved and have a new issue if another culprit is found individually.