Expanding Garrison followers causes Out-of-Memory
gituzzer opened this issue ยท 17 comments
Whenever I open my Lunarfall Garrison in ATT and start looking up/down with the follower list expanded, if I use the sidebar to move the list up and down, WoW freezes while it starts using more and more RAM until WoW goes out of memory after 1 min. or so.
If I do it only going up-down with rolling mouse wheel, ATT memory usage OK and game is usable.
If I collapse the Followers list (it has 244 items), ATT memory usage OK and game is usable.
I've got 32GB RAM and typically ATT uses about 500MB (overall WoW uses 4GB).
Reproducible.
I think this is still a known issue. You can drag the scrollbar and somehow this triggers something which causes WoW to infinitely stay locked and memory usage sky-rockets. Extremely hard to test what specifically causes this problem since once it happens, the only option is force closing the game. My suspect is on the loading of NPC portraits into the ATT rows, but haven't figured it out.
@ImUnicke, so you can't replicate it as well? I remember that I could replicate before but not anymore ๐ค Tried dragging the bar as fast as I can, in debug too, no luck.
@Darkal31, oh, that's interesting. Can you provide your settings? Maybe it somehow affects this...
It has to be something with followers for sure, all modes where I enabled folowers caused this lag (even followers only). I tried to open insanely huge groups like right clicking outdoor zones in debug with 128k items and no lag there when scrolling through.
I am also able to replicate that on opened Legion Class Hall group where there is few followers too.
Interesting. It was reported before when scrolling through the Battle Pet section in the Main list or popout as well. But helps to know that Followers might be a key component in the issue. Will have to research it further at some point.
Also, crazy that your game actually finished 'doing something' @Darkal31 and managed to stabilize. I guess that means there's no infinite loop being triggered? Not sure....
I think that was my system stopping it (not sure tho), but my screens went black for 2s and then the wow stopped 'doing something' and was playable again.
Maybe it's something with icons of followers? All items load immediately or at least are probably cached after loaded once, but followers always seem to load again when going through them again. When I go faster in the list I can see the icons loading slower and it's blank for a very short time. When I go super fast, no icons load at all and that causes the lag. @ImUnicke
Maybe it's something with icons of followers? All items load immediately or at least are probably cached after loaded once, but followers always seem to load again when going through them again. When I go faster in the list I can see the icons loading slower and it's blank for a very short time. When I go super fast, no icons load at all and that causes the lag. @ImUnicke
Quite possible. This is why I thought it had to do with loading of the NPC icons in the rows, but if it doesn't happen for expanded Outdoor Zone content, then maybe it is specific to followers and not just NPCs in general.
Followers does need caching logic implemented though which would greatly improve performance potentially for loading many followers at once. So potentially adding that logic could be enough to prevent this issue. I'll try to get that done later tonight and push it up to Git and perhaps we will see if anything is different.
When I go faster in the list I can see the icons loading slower and it's blank for a very short time.
That's also the case for me but they do load eventually later no matter how fast I scroll.
Well I guess I might have to comment out bits of code and see when the issue stops happening to know what the true source of the issue is...
When I commented out the loading of the follower icon in the ATT rows, the issue stopped happening for me. So definitely seems related to that code somehow.
I can replicate this, though the result does not cause an OOM error; memory starts growing very rapidly and the game freezes, after a minute or so when the game has eaten up ~10gb of ram, it will flicker and the game will become playable again. The game does release the additional ram resources after a minute or two after the game starts to be responsive.
To get this behavior I expanded the EF > Garrison > Buildings > Followers and slowly scrolled down, then I clicked on the scrollbar to go to a specific point and I scrolled back with my wheel.
I have encountered similar in the past with old ATT versions when you would have a window will all items recursively expanded and you would do some excessive scrolling, it seems to cause everything to load at once instead of queuing it.
If it is any helpful; then I play on Unique mode