BigWigs Boss Mods (BW) - DBM alternative

BigWigs Boss Mods (BW) - DBM alternative

140M Downloads

[MC] Shazzrah's Gate timers

lucasvienna opened this issue ยท 1 comments

commented

This issue addresses two things:
2. No bar for the 1st gate shows up
3. Median timer for the subsequent Gates can be too long.

I have proposed fixes/enhancements and can submit a PR as well.

What steps will reproduce the problem?

Not a bug.

What version of BigWigs are you using? (Stating 'latest' is not useful)

v12.1-classic

Do you have an error log of what happened?

No errors, no logs.

Any additional information? (example: WoW language if not English) (Attach screenshots here if available, do not link externally)

DBM uses a 30s timer for the first gate, and that seems to be fairly accurate, with a certain range for error. Any reason why this wasn't implemented in BW? It's a fairly quick fix:

function mod:OnEngage()
	self:Bar(19715, 10.7) -- Counterspell
	-- // add this line //
	self:Bar(23138, 30)   -- Blink
end

For any subsequent gates: time can be between 41-50s. I propose BW uses the smallest value as a baseline instead of the current 45s in order to prevent early casts. Worst case scenario, spell will fire 10s after the bar disappears.

function mod:Blink(args)
	self:Bar(23138, 41). -- change this number to 41 instead of 45
	self:Message(23138, "red")
end
commented

I opened the PR as mentioned, hope the maintainers find it acceptable!