Buffet

Buffet

Addons
91.8k Downloads

Health value not taking million into account

Hemario opened this issue ยท 3 comments

commented

Describe the bug
Darkstem Stew (https://www.wowhead.com/item=215448/darkstem-stew) is choses as best over Crystal Tots (https://www.wowhead.com/item=227301/crystal-tots). The tooltip shows "4.3 million" instead of the actual full number.

image

image

Some debug information of the 2 items:

 Buffet: Item [Darkstem Stew]: 
 Buffet: - Is health: Yes 
 Buffet: - Is mana: No 
 Buffet: - Is well fed: No 
 Buffet: - Is conjured: No 
 Buffet: - Is percent: No 
 Buffet: - Is potion: No 
 Buffet: - Is toxic potion: No 
 Buffet: - Is bandage: No 
 Buffet: - Is over time: No 
 Buffet: - Is restricted:  No 
 Buffet: - health value: 321428 
 Buffet: - mana value: 0 
 Buffet: - itemClassId: 0 
 Buffet: - itemSubClassId: 5 

 Buffet: Item [Crystal Tots]: 
 Buffet: - Is health: Yes 
 Buffet: - Is mana: No 
 Buffet: - Is well fed: No 
 Buffet: - Is conjured: No 
 Buffet: - Is percent: No 
 Buffet: - Is potion: No 
 Buffet: - Is toxic potion: No 
 Buffet: - Is bandage: No 
 Buffet: - Is over time: No 
 Buffet: - Is restricted:  No 
 Buffet: - health value: 3 
 Buffet: - mana value: 0 
 Buffet: - itemClassId: 0 
 Buffet: - itemSubClassId: 5
commented

Please have a try at version 118. Unfortunately I'm unable to test the fix as I do not have a subscription at the moment.

commented

This number format is indeed not supported (yet), I'll have a look, it should be an easy fix.

commented

Preliminary test is looking fine. I will keep you updated in case some other things would break.

 Buffet: Best item ids: 
 Buffet: bests.healthPotion=212242 
 Buffet: bests.drink=227327 
 Buffet: bests.food=227301 
 Buffet: bests.manaPotion=212242 
 Buffet: bests.wellFedFood=222728 

 Buffet: Item [Darkstem Stew]: 
 Buffet: - Is health: Yes 
 Buffet: - Is mana: No 
 Buffet: - Is well fed: No 
 Buffet: - Is conjured: No 
 Buffet: - Is percent: No 
 Buffet: - Is potion: No 
 Buffet: - Is toxic potion: No 
 Buffet: - Is bandage: No 
 Buffet: - Is over time: No 
 Buffet: - Is restricted:  No 
 Buffet: - health value: 321428 
 Buffet: - mana value: 0 
 Buffet: - itemClassId: 0 
 Buffet: - itemSubClassId: 5

 Buffet: Item [Crystal Tots]: 
 Buffet: - Is health: Yes 
 Buffet: - Is mana: No 
 Buffet: - Is well fed: No 
 Buffet: - Is conjured: No 
 Buffet: - Is percent: No 
 Buffet: - Is potion: No 
 Buffet: - Is toxic potion: No 
 Buffet: - Is bandage: No 
 Buffet: - Is over time: No 
 Buffet: - Is restricted:  No 
 Buffet: - health value: 3.6e+06 
 Buffet: - mana value: 0 
 Buffet: - itemClassId: 0 
 Buffet: - itemSubClassId: 5