Cell - Unit Frames

Cell - Unit Frames

343k Downloads

[Bug] "Time to hold" cast bar option supports decimal values but always rounds up in settings menu

michaelbull opened this issue ยท 0 comments

commented

Addon Version

1.4.32

World of Warcraft Version

Retail

Describe the bug

Thanks so much for the work on the Interrupted cast bar state (#163), it works amazingly well.

The 'time to hold' input in the cast bar settings suggests that you can only enter whole seconds as the input. I can manually type in 0.7, and it will stay there. Upon re-opening the settings menu, the 0.7 is rounded-up to 1. The rounding upwards is merely a visual bug, as the actual underlying value is still 0.7.

Ultimately, I do want to be able to actually set decimal values as my preferred value is 700ms - so I think the solution here is to solve the settings menu incorrectly rounding it upwards, and to then change the tooltip to indicate that decimal values are acceptable.

Steps to reproduce

  1. Enable player cast bar
  2. Set time-to-hold to 0.7
  3. Enable target cast bar
  4. Set time-to-hold to 1
  5. Target yourself
  6. Cast a spell and manually interrupt it
  7. Observe that the player's cast bar disappears after 0.7 seconds, and the target's cast bar disappears after 1.0 seconds
  8. Observe that the settings menu says 1 second for both of the time-to-hold options for both cast bars, despite them disappearing at different speeds

BugSack