Classic Floating Combat Text

Classic Floating Combat Text

614k Downloads

Per-Spell Merge Interval

akbyrd opened this issue ยท 5 comments

commented

I absolutely love the addon. It does a great job of merging events, unlike other combat text addons I've tried.

I do have a request regarding merging though. I'd like to be able to set a per-spell interval. Fury Warriors have a couple of spells that perform multiple hits over a small duration. Namely, Whirlwind and Rampage. In order to merge all of these events properly and show a single hit I have to set my interval to 0.6 seconds, measured from the first event. Unfortunately, this is a rather log duration and has the effect of making the combat text for all my other abilities feel pretty slow.

I'd like to be able to keep the global interval to something like 0.1 seconds, then add an override specifically for Whirlwind and Rampage that raises the interval slightly to capture all the events. Parrot is another combat text addon that has this custom interval support.

If the context helps at all, here's the overall look I have set up.
Scrolling Combat Text

commented

In addition to things in #5 at least in my case whirlwind starts getting completely merged with an interval setting of 0.21 (210ms) from last event. It isn't completely reliable because the time between events is variable depending on connection quality.
When an event happens time is counted down from the interval setting to 0, when it reaches 0 the next event won't get merged into the last one.

When I set the interval to 0.3 (300ms) whirlwind always gets completely merged and the delay of all other instant abilities is actually about the same as the default blizzard's damage text. With a lower interval setting or no merging enabled the addon shows damage text sooner than blizzard's code would.

With all that in mind I may add an interval override for different merge categories. Not sure when I'll add it to the UI tho.

commented

Whirlwind isn't as bad as Rampage. Rampage is actually the one that drives it all the way up to 0.6 for me. It mostly works at 0.5 but to get 99% coverage you have to a go a good bit higher.

It isn't completely reliable because the time between events is variable depending on connection quality.

It looks like you take your own timestamp when handling events instead of using the one that's part of the event payload. Is that intentional? I'd hope the latter doesn't depend on connection, but maybe it's unreliable for some reason?

With all that in mind I may add an interval override for different merge categories.

What are the merge categories?

commented

What are the merge categories?

need at least 2 categories for tracking by spell ids or spell icons.

commented

working on this

commented

Added this