Core Loot Manager DKP & EPGP & SK

Core Loot Manager DKP & EPGP & SK

1M Downloads

Wrong GP values for ranged weapons

dcarril opened this issue ยท 1 comments

commented

The Dynamic item values configuration does not properly calculate the GP value for Ranged weapons. Bows GP are properly calculated with the Ranged modifier, but crossbows and guns are calculated with the Ranged (wands) modifier.

After a brief conversation in Discord we found out the issue is the weapon type. Bows are INVTYPE_RANGED, but crossbows and guns are INVTYPE_RANGEDRIGHT.

Siren's Cry (Ulduar bow) dump info:
image

Skyforge Crossbow (Ulduar crossbow) dump info:
image

AddOn version: ClassicLootManager-v2.5.4-wrath
Game Version: Wrath of the Lich King Classic - v3.4

commented

@lantisnt this issue is still happening for dynamic values. I've reviewed the code and if I'm not mistaken is due to the dynamic values being calculated in ItemValueCalculator.lua instead of Roster.lua.

Here can be seen how dynamic values are still using the item equip location returned by WoW API: https://github.com/ClassicLootManager/ClassicLootManager/blob/46dd02995fc97c9b4dfcc98993918c2e932e1b14/Modules/RosterManager/ItemValueCalculator.lua#L147-L164

Would it be possible to implement the crossbows and guns workaround there as well?