Core Loot Manager DKP & EPGP & SK

Core Loot Manager DKP & EPGP & SK

2M Downloads

CLM Gargul integration for SoftReserve

SentinelMantik opened this issue · 2 comments

commented

Is your request related to a problem? Please describe.
We're trying to use CLMs Gargul integration, while using softres.it for reserves. While doing so, the points for normal MS and OS rolls are deducted correctly. Only the selection for "Prioritized MS" and "Prioritized OS" is not deducted when awarding any reserved item. The value of Regular MS and OS is used. Since we don't utilize TMB we do not have the "Prioritized" information during rolls.

Describe the solution you'd like
Ad two more selections for "Reserved MS" and "Reserved OS" under Gargul Integration, so that the correct values are deducted. Addin additional event-handler to not mix with the prioritized status.

Describe alternatives you've considered
I changed my local addon to also evaluate the status of the getGargulAwardActionName for "isReserved" an then invoke the same events as for "isPrioritized" as a workaround

Additional context
the "isReserved" status is allready questioned in the statement "getGargulAwardActionName" just not used for any evaluation.

commented

Quick Fix i added as a workaround in integrations.lua:

local function getGargulAwardActionName(isOs, isWishlisted, isPrioritized, isReserved)
if not isOs and isPrioritized then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.PRIORITY_MS end
if isOs and isPrioritized then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.PRIORITY_OS end
if not isOs and not isPrioritized then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.REGULAR_MS end
if isOs and not isPrioritized then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.REGULAR_OS end
if not isOs and isReserved then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.PRIORITY_MS end
if isOs and isReserved then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.PRIORITY_OS end
if not isOs and not isReserved then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.REGULAR_MS end
if isOs and not isReserved then return PRIV.CONSTANTS.EXTERNAL_LOOT_AWARD_ACTION_HANDLER.REGULAR_OS end
end

but, as this could clash with users, utilizing both TMB and SR, i do not recommend this as a solution.

commented

Will be added in next release.