New bind spell doesn't work but spell works from spellbook
jermoo opened this issue ยท 7 comments
Describe the bug
as indicated in the title. It appears that having the spell bound multiple times in different profiles may cause the spell bind to fail if it's in the global configuration. The fix is to find it in the non-global section and remove them. Then the global works. I'm not sure if this is consistent or only with my setup.
Clicked Version
1.16.11
World of Warcraft Flavor
Retail
Tried with only Clicked enabled
- Yes
- No
Lua Errors
No response
Reproduction Steps
have a global spell bind on one character and the same bind on another but non-global. the spell won't fire
Last Working Version
No response
Screenshots
No response
Debug Output
No response
related to the orphans feature request post. Clicked.zip
it could be orphans or duplicates. The spell with the issue is whirling surge spell ID #361584 bound to Numpad 3.
searching the clicked.lua shows multiple entries for spell id 361584 (whirling surge). There are 14 spells with scope 2 (global) and many instances of spell id 361584 having a scope of 1 (not global) for the mythicmeow user. This is where I believe the issue is happpening. I'm working to understand the field layout of the clicked.lua and am close. I have backups of the file.
I may have this "fixed". I changed all instances (NOT RECOMMENDED) of the spellID 361584 Scope to 2. Then logged on and deleted the bind and re-created it (I had already tried this BEFORE monkeying with the file). I then found TWO binds for that spell where previously there was only one showing in the UI. I deleted the non-global version and now it works. The same action taken on all affected characters is now showing two binds for that spell. Deleting both and re-creating the bind as global seems to work without any issues. Odd behavior. I've not looked at the code to see how/where the root issue is. This could be fixed in code or in the DB. It's my opinion that the code should over-write all instances of a spell in a given profile (regardless of if it's bound) if/when a new bind for the same spell is created. This may already be the case. I'm just not sure how/why this occurred. I believe it's partially related to using the copy profile feature where the issue started with the mythicmeow profile and I copied it for each new character.
Hm interesting. Do you know if those the bindings you deleted had non-unique uids? There should be a field in the data for uid. If that is identical to another binding it'll cause only one to show up in the UI
back to broken. odd, I'll check the UIDS. I keep a version file so I have the original
4 entries for whirling surge had the same UID but 3 didn't. No duplicates for other spells, meaning ["uid"] = 21 isn't on a different spell anywhere, however, I did find UIDs that started with 21.. e.g. 21xx. I'd expect the code would differentiate so..shrug. I'll remove all instances of the spell and create one global. Not sure how it happened but I had it working then it broke. All I did was relog. My preference is if a spell is made global that all other instances be removed if the bind/conditionals are the same??