Clicked

Clicked

294k Downloads

"Open the unit menu" does not work when grouped with a spell cast

KyrosKrane opened this issue ยท 1 comments

commented

Describe the bug

My goal is to create a flow as follows, bound to the right mouse button and clicked on a unit frame. The keybinding should pick the first applicable scenario. My intent is to use these to click the unit frame of a target that needs a quick rez in combat.

  1. If target is friendly and dead, and I'm in combat, cast combat rez.
  2. If target is friendly and dead, and I'm not in combat, cast normal rez.
  3. For any other case, show the default unit menu.

If I create a Clicked binding for "Open the unit menu" alone, it works. If I combine that with any spell on the same keybind, it doesn't work. Either the menu always shows, or it always tries to cast the spell.

For the reproduction steps below, I used Blessing of Freedom, due to a much shorter recast and not needing a nearby player corpse. :) The desired flow for that is:

  1. If target is friendly, cast Blessing of Freedom.
  2. For any other case, show the default unit menu.

Clicked Version

Clicked 1.16.12

World of Warcraft Flavor

Retail

Tried with only Clicked enabled

  • Yes
  • No

Lua Errors

None.

Reproduction Steps

For ease of testing, I'm using a level 80 paladin with the spell Blessing of Freedom. However, the same steps can be done with the paladin rez spells, Redemption (non combat) and Intercession (combat). Testing should be done in an area with both friendly and hostile targets nearby - the training dummy area in Dornogal is what I used. When testing, be sure to allow time for BoF to come off cooldown between test scenarios.

  1. While logged out, delete your Clicked.lua saved variable file, to ensure a fresh start.
  2. Log in to your character with only Clicked enabled.
  3. Type /clicked to open the config UI
  4. On the right hand side, next to Open the unit menu, click Create.
  5. Click on Unbound, and click the right mouse button to bind BUTTON2
  6. Click the Targets tab, then check the box next to unit frame.

Test 1:
Right click on your unit frame, then right click on the unit frame of a nearby hostile target (such as a training dummy).
Expected result: The context menu should open in all cases.
Actual result: The context menu should open in all cases.

  1. Click the New button to create a new binding.
  2. Next to Cast a spell on a unit frame click Create
  3. Click on Unbound, and click the right mouse button to bind BUTTON2
  4. Click the Action tab. Under Target Spell, type Freedom, then click Blessing of Freedom in the spell list.
  5. Click the Targets tab, and ensure the Unit Frame checkbox is checked.
  6. Under Hostility, select Friendly.

Test 2:
Right click on your unit frame.
Expected result: Blessing of Freedom is cast on yourself.
Actual result: The unit menu is opened.

Test 3:
Target a nearby hostile target (such as a training dummy) and right click on its unit frame.
Expected result: The unit menu is opened.
Actual result: The unit menu is opened.

  1. Right click the binding for Open the unit menu and choose Delete. Click Yes in the popup box.
  2. Click the New button.
  3. Repeat steps 4-6 to create a new binding for the menu.

Test 4:
Right click on your unit frame.
Expected result: Blessing of Freedom is cast.
Actual result: Blessing of Freedom is cast.

Test 5:
Target a nearby hostile target (such as a training dummy) and right click on its unit frame.
Expected result: The unit menu is opened.
Actual result: Blessing of Freedom is cast on yourself.

Test 6:
Target a nearby friendly target (such as a same-faction player or a healing training dummy) and right click on its unit frame.
Expected result: Blessing of Freedom is cast on the target.
Actual result: Blessing of Freedom is cast on the target.

Last Working Version

Not tested with prior versions

Screenshots

n/a - see reproduction steps above.

Debug Output

n/a