MoP Classic Beta Issues
Closed this issue · 15 comments
Well, with MoP pre-patch for 5.5 coming in a few weeks (July 1st), I have a few bugs that are affecting DMF.
I did as you suggested, and updated the line for classic to read
local isCataClassic = (WOW_PROJECT_ID == WOW_PROJECT_MISTS_CLASSIC)
And the add-on mentions that the faire is available...
But does not detect that I am in the fenced area to show the DMF window. So I load it manually (/dmfq) and go talk to the vendor. However Autobuy isn't buying it....
Even when I manually buy the items, the DMF window is unchanged...
I tried a /reload but it doesn't update. Not until I walk through the portal to Darkmoon Island, then it updates....
After I leave Darkmoon Island, I reopen the DMFQ window, and it does show updated quest info.
I'd like to add that there are no LUA error whatsoever, woot! So it might just be a logic detection thing going on?
Thanks!
Ok, I looked up the map ID from line 189 in the add-on code, and it looks like they are changing the map ID to match Retail. So Line 199 could remove the 1429 ID and only use 37. Or however that works.
Hope this helps!
My quick little fix to Line 199
[isRetail and 37 or 37] = { -- Elwynn Forrest
Very kludgy, but it fixed the detection of the zone/sub-zone, AND AutoBuy. I'm certain the Horde ones will be just as easy to fix....
Cheers!
Thanks for finding out the use of Retail uiMapIDs. I have already done some changes. that I know need to be done, on my end and I'm soon going to create a new branch with the MoP Classic changes.
If you have time at any point, could you check some of these commands ingame:
/dump PROFESSION_RANKS[#PROFESSION_RANKS][1]- This should return 600.
/tinspect C_QuestLog- If this works, can you search for functions named GetTitleForQuestID, GetQuestInfo and RequestLoadQuestByID in the list.
- If you can't find any, try
/dump IsQuestComplete(29433)- This should return either true or false.
/tinspect C_Item- Check if there are functions named GetItemInfo and GetItemCount in the list.
- If you can't find these, try
/dump GetItemInfo(81055)- This should return info about Darkmoon Ride Ticket.
- Go to the Darkmoon Faire Island and talk to one of the minigame NPCs to open the frame where you can select to start the minigame and use ingame command
/dump C_GossipInfo.GetOptions()and try to see if that dumps any useful information to compare some of the IDs between Retail and (Cata) Classic. - Check if the ingame options looks right. I'm mostly interested in knowing if the texture used in the time offset portion is showing correctly.
- Check the uiMapIDs for the Pandaria capitals with
/dump C_Map.GetBestMapForUnit("player")while inside them.- Should return values between 391-394.
I have pushed my previous changes and your findings to the new MoPClassic-branch. There you can find the updated DMFQuest.lua and DMFQuest.toc (not really needed at the moment, but at least it shouldn't flag the addon as outdated with this).
Ok, here are my findings. I installed the branch you posted, for the testing herein.
Thanks for finding out the use of Retail uiMapIDs. I have already done some changes. that I know need to be done, on my end and I'm soon going to create a new branch with the MoP Classic changes.
If you have time at any point, could you check some of these commands ingame:
/dump PROFESSION_RANKS[#PROFESSION_RANKS][1]
- This should return 600.
It did.
/tinspect C_QuestLog
- If this works, can you search for functions named GetTitleForQuestID, GetQuestInfo and RequestLoadQuestByID in the list.
- If you can't find any, try
/dump IsQuestComplete(29433)- This should return either true or false.
This is included n the 1st screenshot above...
/tinspect C_Item
- Check if there are functions named GetItemInfo and GetItemCount in the list.
- If you can't find these, try
/dump GetItemInfo(81055)- This should return info about Darkmoon Ride Ticket.
That gave me a LUA error....
- Go to the Darkmoon Faire Island and talk to one of the minigame NPCs to open the frame where you can select to start the minigame and use ingame command
/dump C_GossipInfo.GetOptions()and try to see if that dumps any useful information to compare some of the IDs between Retail and (Cata) Classic.
Not sure how useful this is, but this was the result...
Dump: value=C_GossipInfo.GetOptions()
[1]={
[1]={
flags=0,
gossipOptionID=113841,
name="How do I play the Tonk Challenge?",
status=0,
orderIndex=0,
icon=132053,
selectOptionWhenOnlyOption=false
},
[2]={
flags=0,
name="Ready to play! |cFF0008E8(Darkmoon Game Token)|r",
gossipOptionID=113843,
selectOptionWhenOnlyOption=false,
status=0,
orderIndex=2,
icon=132053,
spellID=102191
}
}
- Check if the ingame options looks right. I'm mostly interested in knowing if the texture used in the time offset portion is showing correctly.
Looks ok to me. No issues that I can see.
Check the uiMapIDs for the Pandaria capitals with
/dump C_Map.GetBestMapForUnit("player")while inside them.
- Should return values between 391-394.
Alliance one returned this:
Horde one this:
Cheers!
Great! With this information I should be able to make sure everything uses right functions.
When you checked the uiMapIDs, did you do it only outside, only inside or did you try both/in multiple different spots? If you do more map tests, I just remembered there is built in command /dmfq test to check the current uiMapID (and some other additional info) if it is easier to remember.
In both instances, I was inside the structure, near the innkeeper. I will test some other areas when I get home from work today :)
PTR was down when I got home. It's back up, but Panda zones are still unstable and frequently disconnect. So I can't get any more readings from the capitol cities at the moment. I will try again tomorrow.
I just can't fathom that pre-patch is in two weeks. Panda launch in 5 weeks. Maybe it'll be fine. gulp
Or maybe it will be like that also on live and the fact, that players won't get to play in Pandaria every day, is just Blizzard's ploy to spread out the initial daily quests grind over a longer period of time, so it won't feel like such a boring chore ;)
Or maybe it will be like that also on live and the fact, that players won't get to play in Pandaria every day, is just Blizzard's ploy to spread out the initial daily quests grind over a longer period of time, so it won't feel like such a boring chore ;)
Hahaha
Ok got a few tests done before getting the daily boot.
390 is the area around both shrines. Name changes depending on your exact location however. Similarly, it was 391 for the downstairs area in Shrine of Two Moons, 392 for the upstairs. And for Shrine of Seven Stars, it was 393 for the downstairs, and 394 for the upstairs area.
Thanks for your testing. The reason, why 390 is outside both of the capitals is, because it is the uiMapID for the Vale of Eternal Blossoms, and the name changes based on your location are caused by the different subzones.
I'm leaving this issue open until the pre-patch is applied to the live servers in case you (or anyone else) run into any other problems or anomalities with the addon.
Thanks for your testing. The reason, why 390 is outside both of the capitals is, because it is the uiMapID for the Vale of Eternal Blossoms, and the name changes based on your location are caused by the different subzones.
I'm leaving this issue open until the pre-patch is applied to the live servers in case you (or anyone else) run into any other problems or anomalities with the addon.
Thank you! I will keep at it and I guess we will find out the rest soon enough!
Well, today is the day. Darkmoom faire is active this week already, so I'll see if there is any glitches during pre-patch (the one obvious thing is that we can't learn MoP professions until July 21st). I'll keep you posted after servers are up!