Dungeon Tools

Dungeon Tools

32.8k Downloads

M+ Timer no longer shows percentage of current pull

redcatelf opened this issue ยท 10 comments

commented

As of today, the M+ Timer WeakAura no longer shows the percentage of the current pull, as in this screenshot (+4.62%). Glancing at the code I think the WeakAura uses the global MDT variable, and then MDT:GetEnemyForces. Did something change that broke it?

commented

Namespaced it to DungeonTools to make sure either could be run, together if needed.

I will add a fallback check when an instance is entered to repopulate the MDT global object if it still does not exist (as in, if any other addon is not enabled). In the meantime, you can edit it to use DungeonTools:GetEnemyForces - exactly equal in signature.

commented

I've just pushed 1.1.12, it should be up on wowup in a second and in curseforge in a few minutes. This should solve this issue.

commented

Isn't it possible to put MDT in the the OptionalDeps of the TOC, then check whether it's loaded when DungeonTools loads?

commented

@Ilendur That's actually a really good solution! I did not think of that.

commented

I have upgraded to the latest version and this problem still occurs to me.

commented

Checked further - the MDT reference is in aura init. As a result, adding this on game load would indeed cause problems.

For now, I guess we can live with some namespace clashes; I'll temporarily make the addon also export on MDT on boot instead of 1s after, which should fix this, but mean we're back to having either MDT or dungeontools on.

Really hoping to get a reply re: common interface sometime soon.

commented

Try updating to 1.1.13 and let me know if that fixed it; I've done exactly what @Ilendur suggested and then checked on add-on start if MDT exists. If it doesn't, DungeonTools registers itself on that global as well.

commented

https://wago.io/9TLNEO4Pt/21 used this, can confirm, 1.1.13 works now

commented

Perfect. Back on to the route issue!

commented

Same here, all wa that use MDT as % prevision is broken right now