tainting: lua error about CompactRaidFrame1

Question

tainting: lua error about CompactRaidFrame1

mooreatv opened this issue 5 years ago · 2 comments

mooreatv commented 5 years ago

tainting in combo box?

1x [ADDON_ACTION_BLOCKED] AddOn 'DynamicBoxer' tried to call the protected function 'CompactRaidFrame1:Show()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function `Show'
FrameXML\CompactUnitFrame.lua:367: in function `CompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:299: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:150: in function <FrameXML\CompactUnitFrame.lua:54>

Locals:
InCombatSkipped

mooreatv · Answer 1 · 2019-07-06T17:21:35.000Z

2x [ADDON_ACTION_BLOCKED] AddOn 'DynamicBoxer' tried to call the protected function 'FTLAssist:SetAttribute()'.
!BugGrabber\BugGrabber.lua:519: in function <!BugGrabber\BugGrabber.lua:519>
[C]: in function SetAttribute' DynamicBoxer\ISBoxerPatches.lua:44: in function SetMacro'
DynamicBoxer\DynamicBoxer-@[email protected]:132: in function SetMacro' ISBoxer\ISBoxer_Character.lua:40: in function LoadBinds'
ISBoxer\ISBoxer-1.0.lua:153: in function LoadBinds' DynamicBoxer\DynamicBoxer-@[email protected]:368: in function ProcessMessage'
DynamicBoxer\DynamicBoxer-@[email protected]:384: in function <DynamicBoxer\DynamicBoxer.lua:380>
(tail call): ?

Locals:
InCombatSkipped

mooreatv · Answer 2 · 2019-07-07T02:32:29.000Z

you can see the fix from, before the fix:

7/3 06:22:07.224  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by DynamicBoxer - Interface\FrameXML\UIDropDownMenu.lua:37
7/3 06:22:07.224      securecall()
7/3 06:22:07.224      Interface\FrameXML\UIDropDownMenu.lua:71 UIDropDownMenu_Initialize()
7/3 06:22:07.224      Interface\AddOns\DynamicBoxer\DBoxUI.lua:497 <unnamed>:addDrop()
7/3 06:22:07.224      Interface\AddOns\DynamicBoxer\DBoxUI.lua:599 CreateOptionsPanel()
7/3 06:22:07.224      Interface\AddOns\DynamicBoxer\DynamicBoxer.lua:761

after the fix no more "global variable ... tainted" and just the normal execution path instead

7/6 19:24:47.717  Global variable UIDROPDOWNMENU_MENU_LEVEL tainted by DynamicBoxer - Interface\FrameXML\UIDropDownMenu.lua:37
7/6 19:24:47.717      securecall()
7/6 19:24:47.717      Interface\FrameXML\UIDropDownMenu.lua:71 UIDropDownMenu_Initialize()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\MoLib/MoLibUI.lua:207 <unnamed>:Init()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\MoLib/MoLibUI.lua:24 <unnamed>:Init()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\DBoxUI.lua:445 <unnamed>:HandleRefresh()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\DBoxUI.lua:436
7/6 19:24:47.717      xpcall()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\DBoxUI.lua:435
7/6 19:24:47.717      pcall()
7/6 19:24:47.717      Interface\FrameXML\InterfaceOptionsFrame.lua:218
7/6 19:24:47.717      securecall()
7/6 19:24:47.717      Interface\FrameXML\InterfaceOptionsFrame.lua:305 InterfaceOptionsOptionsFrame_RefreshAddOns()
7/6 19:24:47.717      Interface\FrameXML\InterfaceOptionsFrame.lua:393
7/6 19:24:47.717      InterfaceOptionsFrame:Show()
7/6 19:24:47.717      Interface\AddOns\DynamicBoxer\DynamicBoxer.lua:1188 ?()
7/6 19:24:47.717      Interface\FrameXML\ChatFrame.lua:4836 ChatEdit_ParseText()
7/6 19:24:47.717      Interface\FrameXML\ChatFrame.lua:4497 ChatEdit_SendText()
7/6 19:24:47.717      Interface\FrameXML\ChatFrame.lua:4533 ChatEdit_OnEnterPressed()
7/6 19:24:47.717      ChatFrame1EditBox:OnEnterPressed()

Share to