Spell hit rating does not account for socketed gems
turetafr opened this issue · 7 comments
As stated, the add-on does not reflect socketed gems in the spell hit rating or bonus.
As far as I can tell spell hit is completely wrong. I have 202 spell hit rating wow interface shows this to be 16.01% but this addon says it's 26%.
@RickTee What class and spec do you play? And could you share some screenshots of the wrong values?
@RickTee And talents selected which reduces the hit cap you need?
3 points in suppression, hmm first figures were from spec that had 5 points in suppression. Does that mean each point in suppression gives 2 points of hit but only to affliction spells? The spell hit in the addon would then not apply to destruction spells? or am I as confused as ever.
I am not sure why this didn't pop up earlier @RickTee
Yes, ECS currently adds 0-10% hit for Affliction spells (these lines of code). But as you already pointed at, this doesn't make much sense for Destruction spells 🙈
The big problem of ECS currently is, that it does not list spell hit by school (or talent tree), which is a problem for Mages as well.
I will have to correct this or simply add spell hit by school. But I am very limited in time atm, so I can't promise when this will be fixed, sorry :/
Hey @turetafr Thanks for the hint, I will have to look into this to check what I can do about it 👍🏻