Bug description

Since 1.14 patch (in Classic ERA) addon still runs and window shows but Settings button does nothing and stats shown cannot be changed (and have forgotten previous settings).

Screenshots

Version

Classic ERA 2.8.11-era

Hi again,
Sorry for the delay. I've tried that now and sadly just the same problem, Settings doesn't work and throws the same error.
I don't suppose there is a way of manually (ie. without using the Settings menu in-game) to control the settings for which Stats are shown? I'd be very happy if i could just set it to see the caster stats and not the melee ones please!

Message: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Time: Fri Oct 8 17:50:39 2021
Count: 1
Stack: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Locals:

Also, now I think about it and scroll through the other LUA errors, there's a whole lot about AceConfig-3.0 from other addons. eg.:
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:568: attempt to call method 'SetBackdrop' (a nil value)
Not sure if that helps you at all. Guessing maybe it's ACE that's broken and not your excellent addon itself...

also - although stats are shown, I've just noticed they do not change when swapping gear, etc - so maybe more is broken than I first though sadly.

I think you're bang on with the "nul" idea. :)

Error on opening character pane (with ECS turned on):
Message: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Time: Wed Oct 6 21:08:38 2021
Count: 1
Stack: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Locals:

Error clicking Settings button:
Message: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Time: Wed Oct 6 21:11:20 2021
Count: 2
Stack: ...face\AddOns\ExtendedCharacterStats\Modules\Stats.lua:56: attempt to index global 'ECSConfigFrame' (a nil value)
Locals:

Lots of the other errors, from other addons are also nil value related, mostly "attempt to call method 'SetBackdropBorderColor' (a nil value)" - in case this helps you at all.

Thanks for posting the error messages @derastoby

Actually this is not really what I expected to be nil 😅 ECSConfigFrame is something that ECS creates using an external dependencies (AceGUI library). Not sure what is going on on the new PTR servers and the version used there.

Yeah I already read, that "all" Backdrop related APIs are gone with 1.14.1.

A shot in the blue @derastoby

Could you change one line of your ECS installation and see if that helps (or breaks even more)?

https://github.com/BreakBB/ExtendedCharacterStats/blob/master/Modules/Config/Config.lua#L35

Try to change:

    ECSConfigFrame = configFrame.frame;

to

    ECSConfigFrame = configFrame;

Then do a /reload

Hey @derastoby Thanks for letting me know. Once I have time for ECS again I will check that 🙈 Could you do me a favor and try the following:

/run ExtendedCharacterStats.general.profileVersion = 0 and then do a /reload?

Thanks for the help! :)
On reload I saw:
"[ECS]: Migrating ECS profile version fro 0 to 10"
It has changed what's shown in the ECS window, now see a lot of melee stats - probably the same as the default setup.
I can scroll down them, but not right down to below the "Spell" line (unless all spell stats are turned off).
Settings button sadly still does not work.
Hope this help you a little in figuring it out. ECS is much less broken than some other addons by the way, hopefully it easy to fix. :)

Yeah correct, your settings should be reset to default now. Do you have any error you could share @derastoby ?

I guess I should just test it myself and ship an update. Problem is that I currently are very limited in time 🙈

For others reading this: Most likely some API function changed, which is now nil and therefore breaks ECS. I'd appreciate help via PRs to get this fixed soon ™️

Hey @derastoby would you mind testing this version. I was able to reproduce your error and I think I also found the issue:

ExtendedCharacterStats-v2.8.11-era-913e4f9.zip

Hey - thanks for the new version!
Good news - settings button works, as do settings and most values for stats!
Bad news - Spell Hit % calculation seems to be way wrong - based on taking gear on/off I think it is adding 7x the correct value. With my raid boss gear on it shows 70% hit!
Spell crit is also wrong - I don't think it is adding anything for items with +crit on them at all, only changing the crit value for intellect. Druid's Moonkin form should be +3% but seems to be +8%.

Melee attack power and melee crit look OK, I don't have any melee +hit gear on to test that.
FYI - I saw "Migrating ECS Profile from 10 to 11" at load time.
Thanks again, if you could fix these last few bits, that'd be amazing please!
Deras.

@derastoby Thanks once again for reporting back on this issue 🙏🏻

Could you tell me which class you are playing and show me your skill tree? That would be helpful to investigate what exactly is going on.

You are very welcome - happy to help such a great addon/creator!
I play a Moonkin druid, so no talents that add to spell hit (sadly).
I did just try another stats addon and it appears to have exactly the same problem for Spell Hit, with the odd 7x multiplier - although its +Crit appears to work and Boomkin form/aura only adds 3% crit.

Did you actually need a screenshot of my talent trees? I have all the normal moonkin ones, so lots of +damage boosts and so on but no hit or crit (apart from Moonfire crit) - but can screenshot if you need.

Hey @derastoby sorry for not answering on this topic for so long. I've been pretty busy again 🙈

Since you are playing moonkin AND also took the time to test other stat addons, I don't need a screenshot of your talent trees - thanks again for helping out on this.

I can't promise when I will have a solution for this, but I am onto it.

Could you run the following command and report the output?

/dump GetSpellHitModifier()

@derastoby that means the API thinks you have 70% hit, which matches with your report of ECS showing 70% hit in your raid gear.

Could you unequip all your hit gear and run that command again? And then with just one piece of hit gear?

For now it seems that there is an issue on Blizzards side. Alternatively the API changed, which I am unaware of at this point.

Also @derastoby could you try the following:

/dump GetCombatRatingBonus(11)