Extended Character Stats

Extended Character Stats

8M Downloads

Error for Arcane mages Spell power calculation

Mishika08 opened this issue ยท 4 comments

commented

For Arcane mages, spell power shown by the addon is always way higher than the value shown by the game UI (even naked).

Error

In the module "SpellDamage.lua" found in "........\ExtendedCharacterStats\Modules\Data", the spell power modifications from the talents Arcane instability and Mind Mastery are applied to the variable "spellDmg" defined as "local spellDmg = GetSpellBonusDamage(school)". It seems like the value originally stored in this variable is the final one, already affected by the talents. By applying the talents modification afterwards, it doubles their effect.

I tried removing the modifiers and the value shown in the addon was then the same as the game UI.

Corrected

Simply defining the spell damage returned as "local spellDmg = GetSpellBonusDamage(school)" is sufficient.

commented

Hey @Mishika08 that would be a big finding! I will try to verify this on the PTR, as soon I have time ๐Ÿ‘๐Ÿป

commented

Hi ! I hope it will help you =)

commented

Hey @Mishika08 sorry for the late response, but I finally found the time to look into this issue. Here are my results:

The calculation of the "Arcane Instability" bonus is working just fine. The default UI does not reflect the talent as you can see here:

With 0/3 Arcane Instability:
grafik

With 3/3 Arcane Instability:
grafik

Buuuuut, for Mind Mastery you are absolutly correct and the effect is already reflected in the default UI and as well in the API.

0/5 Mind Mastery:
grafik

5/5 Mind Mastery:
grafik

A fix for the latter will be included in the next release. Thank you very much for reporting this ๐Ÿ‘๐Ÿป

commented

Hey ! Sorry I did not see your answer !

Pretty weird that the default UI reflects some of the talents but not all of them. At least you figured out the ones to be included =P

Glad it helped you !