Spell crit% is incorrect in SoM

Question

Spell crit% is incorrect in SoM

gofrikiraly opened this issue 3 years ago · 11 comments

gofrikiraly commented 3 years ago

Items that increase spell crit % in SoM do not change spell crit% at all.
Please see the issue appearing with Eye of the Beast that increases spell crit with 2% but the sheet shows no change whether it is equipped or not

.

BreakBB · Answer 1 · 2022-01-26T21:29:39.000Z

Hey @gofrikiraly this was reported earlier, but since I am not playing SoM and don't have any character to test this it would be great if you could help me out here.

Does the default UI shows the correct values? Can you run the following commands and report what they put out?

/run GetSpellCritChance(1)
/run GetSpellCritChance(2)
/run GetSpellCritChance(3)
/run GetSpellCritChance(4)
/run GetSpellCritChance(5)
/run GetSpellCritChance(6)
/run GetSpellCritChance(7)

Do you have any other item which provides spell crit chance so you could check if it is related to Eye of the Beast or not?

gofrikiraly · Answer 2 · 2022-01-30T18:10:25.000Z

Maybe just to add more to my previous comment: crit is calculated properly but only the part which is based on intellect. The problem is with + crit% to be exact.

…

On Sun, 30 Jan 2022 at 15:43, György Kovács ***@***.***> wrote: Hi! The commands do not return anything for me. I tried with different gears, and the result is the same. Only crit does not show up properly and it is not a bug with only Eye of the Beast. Any other idea I could help you out to resolve this? On Wed, 26 Jan 2022 at 22:29, Björn Böing ***@***.***> wrote: > Hey @gofrikiraly <https://github.com/gofrikiraly> this was reported > earlier, but since I am not playing SoM and don't have any character to > test this it would be great if you could help me out here. > > Does the default UI shows the correct values? Can you run the following > commands and report what they put out? > > /run GetSpellCritChance(1) > /run GetSpellCritChance(2) > /run GetSpellCritChance(3) > /run GetSpellCritChance(4) > /run GetSpellCritChance(5) > /run GetSpellCritChance(6) > /run GetSpellCritChance(7) > > Do you have any other item which provides spell crit chance so you could > check if it is related to Eye of the Beast or not? > > — > Reply to this email directly, view it on GitHub > <#175 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AK6PB7MVQMDHEJQZJOODZJ3UYBRVHANCNFSM5MURL2UQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

gofrikiraly · Answer 3 · 2022-01-30T14:43:55.000Z

Hi! The commands do not return anything for me. I tried with different gears, and the result is the same. Only crit does not show up properly and it is not a bug with only Eye of the Beast. Any other idea I could help you out to resolve this?

…

On Wed, 26 Jan 2022 at 22:29, Björn Böing ***@***.***> wrote: Hey @gofrikiraly <https://github.com/gofrikiraly> this was reported earlier, but since I am not playing SoM and don't have any character to test this it would be great if you could help me out here. Does the default UI shows the correct values? Can you run the following commands and report what they put out? /run GetSpellCritChance(1) /run GetSpellCritChance(2) /run GetSpellCritChance(3) /run GetSpellCritChance(4) /run GetSpellCritChance(5) /run GetSpellCritChance(6) /run GetSpellCritChance(7) Do you have any other item which provides spell crit chance so you could check if it is related to Eye of the Beast or not? — Reply to this email directly, view it on GitHub <#175 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK6PB7MVQMDHEJQZJOODZJ3UYBRVHANCNFSM5MURL2UQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

BreakBB · Answer 4 · 2022-01-31T13:47:35.000Z

Argh @gofrikiraly I posted the wrong commands. Can you use /dump instead of /run? 🙈

gofrikiraly · Answer 5 · 2022-01-31T15:25:29.000Z

Hi again! It seems the 1st one returns something different. See the outputs below: Dump value=GetSpellCritChance(1) [1] 6.0631999969482 Dump value=GetSpellCritChance(2) [1] 10.063199996948 Dump value=GetSpellCritChance(3) [1] 10.063199996948 Dump value=GetSpellCritChance(4) [1] 10.063199996948 Dump value=GetSpellCritChance(5) [1] 10.063199996948 Dump value=GetSpellCritChance(6) [1] 10.063199996948 Dump value=GetSpellCritChance(7) [1] 10.063199996948

…

On Mon, 31 Jan 2022 at 14:47, Björn Böing ***@***.***> wrote: Argh @gofrikiraly <https://github.com/gofrikiraly> I posted the wrong commans. Can you use /dump instead of /run? 🙈 — Reply to this email directly, view it on GitHub <#175 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK6PB7NPC45G5IWITXNLBOTUY2HIDANCNFSM5MURL2UQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

BreakBB · Answer 6 · 2022-02-01T06:13:41.000Z

Thanks @gofrikiraly The numbers differ to the screenshot you posted above. Is 10% spell crit what you expected to have? 🤔

kjmd75 · Answer 7 · 2022-02-08T07:24:30.000Z

@BreakBB It does not. With or without the Eye of the Beast, it shows the same value. While the other ones do change.

gofrikiraly · Answer 8 · 2022-02-08T07:29:03.000Z

I think it happens because the eye of the beast adds only spell crit. Spell crit is the stat that does not show up. Normally, as other items add intellect as well they add some spell crit by because of intellect, but they do not add they spell crit stat. E.g. the exalted AV ring adds spell crit % as well and it does not show up properly either.

…

On Tue, 8 Feb 2022 at 08:24, kjmd75 ***@***.***> wrote: @BreakBB <https://github.com/BreakBB> It does not. With or without the Eye of the Beast, it shows the same value. While the other ones do change. — Reply to this email directly, view it on GitHub <#175 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK6PB7I557DJH422CL3ND2DU2DALRANCNFSM5MURL2UQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

kjmd75 · Answer 9 · 2022-02-08T05:47:35.000Z

@BreakBB I'm having the same issue and ran the same dump commands. Basically GetSpellCritChance(1) is what is being shown, but values 2-7 are the right values.

BreakBB · Answer 10 · 2022-02-08T06:24:48.000Z

Morning @kjmd75 thanks for letting me know. Just to make sure: Does the value of GetSpellCritChance(1) change without Eye of the Beast equipped?

BreakBB · Answer 11 · 2022-02-08T11:24:42.000Z

Yeah @gofrikiraly that is the issue. But it is one the Blizzard API has and which is not properly documented.

But the fix will be easy then. Thanks everyone for helping to figure this out. I will try to get a fix out for this asap.

Share to