that line uses "GetSpellCritChance(1)" which gets the spell crit chance for physical spells.
those usually aren't affected by items that give additional crit chance what leads to Spellcrit for specific schools displaying the wrong value.

if i'm not wrong that line should instead be "crit = crit + GetSpellCritChance(school) + itemBonus + setBonus".

Yes @WrIgHtaufGanovenjagd you are right. We also discussed this in #178 and I will get out a fix for this in a bit.