Extended Character Stats

Extended Character Stats

Addons
8M Downloads

Mage Crit Incorrect - Critical Mass Talent Selection

NayooZ opened this issue ยท 0 comments

commented

Bug description

Mage Crit values are incorrect in version 3.1.3 & 3.1.4

In 3.1.2 the ECS values match the character sheet
In 3.1.3 and 3.1.4 they are incorrect by -2% as the underlying code was changed slightly - related bug #247

This is due to the Critical Mass talent not being selected by the correct value. As shown in below dumps it is grabbing the Burning Soul talent (2,1) instead of (2,11) for Critical Mass. My spec has 2/2 Burning Soul therefore it is currently giving 4% crit in ECS rather than the 3/3 Critical Mass for 6%.

Burning Soul is (2,1) in HC/Era/Wotlk.
Critical Mass is (2, 11) in HC/Era/Wotlk.

SpellCrit.lua

    if classId == Data.MAGE then
        local _, _, _, _, criticalMassPoints, _, _, _ = GetTalentInfo(2, 1)
        mod = criticalMassPoints * 2 -- 0-6% Critical Mass

Data Dump

WRATH

[19:48] Dump: value=GetTalentInfo(2, 1)
[19:48] [1]="Burning Soul",
[19:48] [2]=135805,
[19:48] [3]=3,
[19:48] [4]=4,
[19:48] [5]=2,
[19:48] [6]=2,
[19:48] [8]=1,
[19:48] [9]=2,
[19:48] [10]=1,
[19:48] [11]=23

[19:52] Dump: value=GetTalentInfo(2, 11)
[19:52] [1]="Critical Mass",
[19:52] [2]=136115,
[19:52] [3]=5,
[19:52] [4]=2,
[19:52] [5]=3,
[19:52] [6]=3,
[19:52] [8]=1,
[19:52] [9]=3,
[19:52] [10]=1,
[19:52] [11]=33

HC

[20:31:17] Dump: value=GetTalentInfo(2, 1)
[20:31:17] [1]="Burning Soul",
[20:31:17] [2]=135805,
[20:31:17] [3]=3,
[20:31:17] [4]=4,
[20:31:17] [5]=0,
[20:31:17] [6]=2,
[20:31:17] [8]=1,
[20:31:17] [9]=0,
[20:31:17] [10]=1,
[20:31:17] [11]=23

[20:23:26] Dump: value=GetTalentInfo(2, 11)
[20:23:26] [1]="Critical Mass",
[20:23:26] [2]=136115,
[20:23:26] [3]=5,
[20:23:26] [4]=2,
[20:23:26] [5]=0,
[20:23:26] [6]=3,
[20:23:26] [8]=1,
[20:23:26] [9]=0,
[20:23:26] [10]=1,
[20:23:26] [11]=33

Screenshots

image
image

Fix

PR: #250

Version

Wrath 3.4.2.50664
HC: 1.14.4.51311
ECS: 3.1.3, 3.1.4