Bug description

49x ...ns/ExtendedCharacterStats/Modules/Data/SpellCrit.lua:151: attempt to perform arithmetic on local 'points' (a nil value)
[ExtendedCharacterStats/Modules/Data/SpellCrit.lua]:151: in function <...ns/ExtendedCharacterStats/Modules/Data/SpellCrit.lua:142>
[tail call]: ?
[ExtendedCharacterStats/Modules/Data/SpellCrit.lua]:81: in function 'GetTalentModifier'
[ExtendedCharacterStats/Modules/Data/SpellCrit.lua]:13: in function <...ns/ExtendedCharacterStats/Modules/Data/SpellCrit.lua:12>
[tail call]: ?
[tail call]: ?
[ExtendedCharacterStats/Modules/Stats.lua]:198: in function <...faceExtendedCharacterStats/Modules/Stats.lua:196>
[ExtendedCharacterStats/Modules/Stats.lua]:189: in function <...faceExtendedCharacterStats/Modules/Stats.lua:178>
[ExtendedCharacterStats/Modules/Stats.lua]:292: in function <...faceExtendedCharacterStats/Modules/Stats.lua:211>
[ExtendedCharacterStats/Modules/Stats.lua]:130: in function 'CreateWindow'
[ExtendedCharacterStats/Modules/Init.lua]:31: in function 'OnPlayerLogin'
[ExtendedCharacterStats/ECS.lua]:36: in function <ExtendedCharacterStats/ECS.lua:29>

Screenshots

Causes the addon to not load properly. (not showing items colors for example)

Change proposal

Change line 151
local _, _, _, _, points, _, _, _ = GetTalentInfo(1, 15) --- Happens to be the talent in the TBC talent tree
To
local _, _, _, _, points, _, _, _ = GetTalentInfo(1, 13) --- Correct talent in the Vanilla talent tree

Version

v4.2.2

Hey @nonotje

Thanks a lot for reaching out and reporting this. Oh wow, that code is in there since 2021 (TBC as you correctly assumed) 😅

Fixed version will be available in a bit!